ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bdev/rbd: add warning message for bdev_rbd_create without specifying -c

Browse Source 
This patch will print warning message to help customer use
rpc command bdev_rbd_create correctly.

Fix issue #2189

Change-Id: I734516bef4c5471249dda6463d81be670d975566
Signed-off-by: Yifan Bian <yifan.bian@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13555
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Xiaodong Liu <xiaodong.liu@intel.com>
Reviewed-by: Dong Yi <dongx.yi@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Yifan Bian 2022-07-06 04:49:10 +00:00 committed by Tomasz Zawadzki
parent 1318b3e434
commit f656eed6e0
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@ -21,6 +21,9 @@ Calculate num_md_pages from num_md_pages_per_cluster_ratio, and pass it to spdk_
New options `ktls` and `tls_version` were added to the `spdk_sock_opts` structure. New options `ktls` and `tls_version` were added to the `spdk_sock_opts` structure.
Added warning message for `bdev_rbd_create`, if it is used without -c.
`bdev_rbd_create()` API without specifying -c is deprecated and will be removed in future release.
## v22.05 ## v22.05
### sock ### sock

2
python/spdk/rpc/bdev.py
View File

@ -982,6 +982,8 @@ def bdev_rbd_create(client, pool_name, rbd_name, block_size, name=None, user=Non
params['config'] = config params['config'] = config
if cluster_name is not None: if cluster_name is not None:
params['cluster_name'] = cluster_name params['cluster_name'] = cluster_name
else:
print("WARNING:bdev_rbd_create should be used with specifying -c to have a cluster name after bdev_rbd_register_cluster.")
if uuid is not None: if uuid is not None:
params['uuid'] = uuid params['uuid'] = uuid