From f656eed6e0853f4fbdc0f2e87e8f1b2e37bd0071 Mon Sep 17 00:00:00 2001 From: Yifan Bian Date: Wed, 6 Jul 2022 04:49:10 +0000 Subject: [PATCH] bdev/rbd: add warning message for bdev_rbd_create without specifying -c This patch will print warning message to help customer use rpc command bdev_rbd_create correctly. Fix issue #2189 Change-Id: I734516bef4c5471249dda6463d81be670d975566 Signed-off-by: Yifan Bian Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13555 Reviewed-by: Changpeng Liu Reviewed-by: Xiaodong Liu Reviewed-by: Dong Yi Reviewed-by: Jim Harris Reviewed-by: Shuhei Matsumoto Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins --- CHANGELOG.md | 3 +++ python/spdk/rpc/bdev.py | 2 ++ 2 files changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 136cfa25f..9c2294e92 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,6 +21,9 @@ Calculate num_md_pages from num_md_pages_per_cluster_ratio, and pass it to spdk_ New options `ktls` and `tls_version` were added to the `spdk_sock_opts` structure. +Added warning message for `bdev_rbd_create`, if it is used without -c. +`bdev_rbd_create()` API without specifying -c is deprecated and will be removed in future release. + ## v22.05 ### sock diff --git a/python/spdk/rpc/bdev.py b/python/spdk/rpc/bdev.py index 49b9dcca9..f997efc8c 100644 --- a/python/spdk/rpc/bdev.py +++ b/python/spdk/rpc/bdev.py @@ -982,6 +982,8 @@ def bdev_rbd_create(client, pool_name, rbd_name, block_size, name=None, user=Non params['config'] = config if cluster_name is not None: params['cluster_name'] = cluster_name + else: + print("WARNING:bdev_rbd_create should be used with specifying -c to have a cluster name after bdev_rbd_register_cluster.") if uuid is not None: params['uuid'] = uuid