ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

build: add -mno-avx512f to x86_64 builds

Browse Source 
valgrind doesn't support AVX-512, and latest compilers
will use newfangled instructions to do simple
integer-to-fp conversions which then break valgrind.

The only place where we would really use or need
AVX-512 is in ISA-L, so disabling those instructions
in SPDK is fine.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I48f3dd4f1b5813485a92c81d01e513c950ada205

Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13554
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
This commit is contained in:
Jim Harris 2022-07-05 17:02:29 -07:00
parent 0098e63676
commit 1318b3e434
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
mk/spdk.common.mk
View File

@ -70,6 +70,13 @@ else
COMMON_CFLAGS += -march=$(TARGET_ARCHITECTURE)
endif
ifeq ($(TARGET_MACHINE),x86_64)
# Don't use AVX-512 instructions in SPDK code - it breaks Valgrind for
# some cases where compiler decides to hyper-optimize a relatively
# simple operation (like int-to-float converstion) using AVX-512
COMMON_CFLAGS += -mno-avx512f
endif
ifeq ($(CONFIG_WERROR), y)
COMMON_CFLAGS += -Werror
endif