Go to file
Shuhei Matsumoto ae620784bd bdev/nvme: Retry I/O to the same path if error is I/O error
When an I/O gets an I/O error, the I/O path to which the I/O was
submitted may be still available. In this case, the I/O should be
retried to the same I/O path. However, a new I/O path was always
selected for an I/O retry.

For the active/passive policy, the same I/O path was selected naturally.
However, for the active/active policy, it was very likely that a
different I/O path was selected.

To use the same I/O path for an I/O retry, add a helper function
bdev_nvme_retry_io() into bdev_nvme_retry_ios() and replace
bdev_nvme_submit_request() by bdev_nvme_retry_io(). bdev_nvme_retry_io()
checks if nbdev_io->io_path is not NULL and is available. Then, call
_bdev_nvme_submit_request() if true, or call bdev_nvme_submit_request()
otherwise. For I/O path error, clear nbdev_io->io_path for
clarification. Add unit test to verify this change.

Linux kernel native NVMe multipath already takes this approach. Hence,
this change will be reasonable.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I7022aafd8b1cdd5830c4f743d64b080aa970cf8d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16015
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Richael <richael.zhuang@arm.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
2023-01-13 00:47:04 +00:00
.githooks Add SPDX header to various files 2022-11-29 08:27:51 +00:00
.github github config: add dependabot.yml 2022-10-26 07:34:10 +00:00
app iscsi_top: remove application 2023-01-11 09:28:08 +00:00
doc nvme: Added support for TP-8009, Auto-discovery of Discovery controllers for NVME initiator using mDNS using Avahi 2023-01-12 17:22:48 +00:00
docker misc: Fix spelling mistakes 2022-12-09 08:16:18 +00:00
dpdk@a887af6880 dpdk: update submodule with clang15 build fixes 2023-01-10 13:09:03 +00:00
dpdkbuild build, config: add CONFIG_HAVE_LIBARCHIVE 2023-01-11 09:27:17 +00:00
examples fio_plugin: initalize when create_serialize=0 2023-01-11 09:17:16 +00:00
go update Intel copyright notices 2022-11-10 08:28:53 +00:00
include accel: Add crypto operation support 2023-01-11 09:16:59 +00:00
intel-ipsec-mb@5b6f01f1d5 intel-ipsec-mb: update submodule to v1.1 2022-01-19 08:51:54 +00:00
ipsecbuild update Intel copyright notices 2022-11-10 08:28:53 +00:00
isa-l@2df39cf5f1 isa-l: update submodule to v2.30.0 2021-01-21 19:24:10 +00:00
isa-l-crypto@08297dc3e7 isa-l_crypto: Add submodule 2022-12-14 08:02:55 +00:00
isalbuild update Intel copyright notices 2022-11-10 08:28:53 +00:00
isalcryptobuild isa-l_crypto: Add submodule 2022-12-14 08:02:55 +00:00
lib lib/event: free the resource in the error case 2023-01-12 08:15:42 +00:00
libvfio-user@4953810d0d libvfio-user: update submodule 2022-08-26 07:41:27 +00:00
licenses license: Rename the directory 2022-07-05 16:43:14 +00:00
mk nvme: Added support for TP-8009, Auto-discovery of Discovery controllers for NVME initiator using mDNS using Avahi 2023-01-12 17:22:48 +00:00
module bdev/nvme: Retry I/O to the same path if error is I/O error 2023-01-13 00:47:04 +00:00
ocf@4477cb55a0 bdev/ocf: Update OCF to 21.6.3.1 2022-05-19 21:00:38 +00:00
proto sma: forbid deleting devices with attached volumes 2022-12-16 09:20:52 +00:00
python/spdk nvme: Added support for TP-8009, Auto-discovery of Discovery controllers for NVME initiator using mDNS using Avahi 2023-01-12 17:22:48 +00:00
rpmbuild add (c) and SPDX header to bash files as needed 2022-11-29 08:27:51 +00:00
scripts nvme: Added support for TP-8009, Auto-discovery of Discovery controllers for NVME initiator using mDNS using Avahi 2023-01-12 17:22:48 +00:00
shared_lib update Intel copyright notices 2022-11-10 08:28:53 +00:00
test bdev/nvme: Retry I/O to the same path if error is I/O error 2023-01-13 00:47:04 +00:00
vfiouserbuild update Intel copyright notices 2022-11-10 08:28:53 +00:00
xnvme@59cca28a61 xnvme: update submodule to v0.5.0 2022-12-21 09:33:27 +00:00
xnvmebuild xnvme: update submodule to v0.5.0 2022-12-21 09:33:27 +00:00
.astylerc astyle: change "add-braces" to "j" for compatibility 2017-12-13 21:23:27 -05:00
.gitignore test/common: don't specify output dir for core_pattern in command line 2022-06-08 17:29:08 +00:00
.gitmodules isa-l_crypto: Add submodule 2022-12-14 08:02:55 +00:00
autobuild.sh autobuild.sh: improve error message for C files that weren't built 2023-01-05 20:22:59 +00:00
autopackage.sh add (c) and SPDX header to bash files as needed 2022-11-29 08:27:51 +00:00
autorun_post.py Add SPDX header to various files 2022-11-29 08:27:51 +00:00
autorun.sh add (c) and SPDX header to bash files as needed 2022-11-29 08:27:51 +00:00
autotest.sh scripts: Ignore RLIMIT_CORE while writing out core dumps 2023-01-10 13:12:21 +00:00
CHANGELOG.md nvme: Added support for TP-8009, Auto-discovery of Discovery controllers for NVME initiator using mDNS using Avahi 2023-01-12 17:22:48 +00:00
CODE_OF_CONDUCT.md doc: add stadnard code of conduct .md file 2022-11-16 09:52:32 +00:00
CONFIG nvme: Added support for TP-8009, Auto-discovery of Discovery controllers for NVME initiator using mDNS using Avahi 2023-01-12 17:22:48 +00:00
configure nvme: Added support for TP-8009, Auto-discovery of Discovery controllers for NVME initiator using mDNS using Avahi 2023-01-12 17:22:48 +00:00
CONTRIBUTING.md Add CONTRIBUTING.md 2017-09-05 13:25:45 -04:00
deprecation.md bdev: examine and register on app thread 2023-01-05 23:28:32 +00:00
LICENSE Use SPDX license identifiers in remaining files. 2022-06-09 07:35:12 +00:00
Makefile isa-l_crypto: Add submodule 2022-12-14 08:02:55 +00:00
mdl_rules.rb markdownlint: enable rule MD003 2021-09-08 21:53:48 +00:00
README.md README: add note for SPDK mailing list 2022-11-17 08:57:59 +00:00
SECURITY.md repo: add SECURITY.md file 2022-10-14 08:35:33 +00:00

Storage Performance Development Kit

Build Status

NOTE: The SPDK mailing list has moved to a new location. Please visit this URL to subscribe at the new location. Subscribers from the old location will not be automatically migrated to the new location.

The Storage Performance Development Kit (SPDK) provides a set of tools and libraries for writing high performance, scalable, user-mode storage applications. It achieves high performance by moving all of the necessary drivers into userspace and operating in a polled mode instead of relying on interrupts, which avoids kernel context switches and eliminates interrupt handling overhead.

The development kit currently includes:

In this readme

Documentation

Doxygen API documentation is available, as well as a Porting Guide for porting SPDK to different frameworks and operating systems.

Source Code

git clone https://github.com/spdk/spdk
cd spdk
git submodule update --init

Prerequisites

The dependencies can be installed automatically by scripts/pkgdep.sh. The scripts/pkgdep.sh script will automatically install the bare minimum dependencies required to build SPDK. Use --help to see information on installing dependencies for optional components

./scripts/pkgdep.sh

Build

Linux:

./configure
make

FreeBSD: Note: Make sure you have the matching kernel source in /usr/src/ and also note that CONFIG_COVERAGE option is not available right now for FreeBSD builds.

./configure
gmake

Unit Tests

./test/unit/unittest.sh

You will see several error messages when running the unit tests, but they are part of the test suite. The final message at the end of the script indicates success or failure.

Vagrant

A Vagrant setup is also provided to create a Linux VM with a virtual NVMe controller to get up and running quickly. Currently this has been tested on MacOS, Ubuntu 16.04.2 LTS and Ubuntu 18.04.3 LTS with the VirtualBox and Libvirt provider. The VirtualBox Extension Pack or [Vagrant Libvirt] (https://github.com/vagrant-libvirt/vagrant-libvirt) must also be installed in order to get the required NVMe support.

Details on the Vagrant setup can be found in the SPDK Vagrant documentation.

AWS

The following setup is known to work on AWS: Image: Ubuntu 18.04 Before running setup.sh, run modprobe vfio-pci then: DRIVER_OVERRIDE=vfio-pci ./setup.sh

Advanced Build Options

Optional components and other build-time configuration are controlled by settings in the Makefile configuration file in the root of the repository. CONFIG contains the base settings for the configure script. This script generates a new file, mk/config.mk, that contains final build settings. For advanced configuration, there are a number of additional options to configure that may be used, or mk/config.mk can simply be created and edited by hand. A description of all possible options is located in CONFIG.

Boolean (on/off) options are configured with a 'y' (yes) or 'n' (no). For example, this line of CONFIG controls whether the optional RDMA (libibverbs) support is enabled:

CONFIG_RDMA?=n

To enable RDMA, this line may be added to mk/config.mk with a 'y' instead of 'n'. For the majority of options this can be done using the configure script. For example:

./configure --with-rdma

Additionally, CONFIG options may also be overridden on the make command line:

make CONFIG_RDMA=y

Users may wish to use a version of DPDK different from the submodule included in the SPDK repository. Note, this includes the ability to build not only from DPDK sources, but also just with the includes and libraries installed via the dpdk and dpdk-devel packages. To specify an alternate DPDK installation, run configure with the --with-dpdk option. For example:

Linux:

./configure --with-dpdk=/path/to/dpdk/x86_64-native-linuxapp-gcc
make

FreeBSD:

./configure --with-dpdk=/path/to/dpdk/x86_64-native-bsdapp-clang
gmake

The options specified on the make command line take precedence over the values in mk/config.mk. This can be useful if you, for example, generate a mk/config.mk using the configure script and then have one or two options (i.e. debug builds) that you wish to turn on and off frequently.

Shared libraries

By default, the build of the SPDK yields static libraries against which the SPDK applications and examples are linked. Configure option --with-shared provides the ability to produce SPDK shared libraries, in addition to the default static ones. Use of this flag also results in the SPDK executables linked to the shared versions of libraries. SPDK shared libraries by default, are located in ./build/lib. This includes the single SPDK shared lib encompassing all of the SPDK static libs (libspdk.so) as well as individual SPDK shared libs corresponding to each of the SPDK static ones.

In order to start a SPDK app linked with SPDK shared libraries, make sure to do the following steps:

  • run ldconfig specifying the directory containing SPDK shared libraries
  • provide proper LD_LIBRARY_PATH

If DPDK shared libraries are used, you may also need to add DPDK shared libraries to LD_LIBRARY_PATH

Linux:

./configure --with-shared
make
ldconfig -v -n ./build/lib
LD_LIBRARY_PATH=./build/lib/:./dpdk/build/lib/ ./build/bin/spdk_tgt

Hugepages and Device Binding

Before running an SPDK application, some hugepages must be allocated and any NVMe and I/OAT devices must be unbound from the native kernel drivers. SPDK includes a script to automate this process on both Linux and FreeBSD. This script should be run as root.

sudo scripts/setup.sh

Users may wish to configure a specific memory size. Below is an example of configuring 8192MB memory.

sudo HUGEMEM=8192 scripts/setup.sh

There are a lot of other environment variables that can be set to configure setup.sh for advanced users. To see the full list, run:

scripts/setup.sh --help

Example Code

Example code is located in the examples directory. The examples are compiled automatically as part of the build process. Simply call any of the examples with no arguments to see the help output. You'll likely need to run the examples as a privileged user (root) unless you've done additional configuration to grant your user permission to allocate huge pages and map devices through vfio.

Contributing

For additional details on how to get more involved in the community, including contributing code and participating in discussions and other activities, please refer to spdk.io