415fa16403
bdev_crypto uses memset() to zero secrets passed by the user (cleanup/error path) which is not safe - compiler may detect that the buffer being zeroed is not accessed any more and may "optimize" (drop) zerofying. C11 standard introduces memset_s which guarantess to change the buffer content, but this function is optional, gcc may not support it. As alternative, add not optimal from performance point of view default implementation. Add unit test to math_ut.c to avoid creating new .c file for 1 simple test Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com> Change-Id: I11c7d15610df02e4a3761a88c85f6f8c54fb4b0a Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16038 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
75 lines
2.1 KiB
C
75 lines
2.1 KiB
C
/* SPDX-License-Identifier: BSD-3-Clause
|
|
* Copyright (C) 2020 Intel Corporation.
|
|
* Copyright (c) 2022, NVIDIA CORPORATION & AFFILIATES.
|
|
* All rights reserved.
|
|
*/
|
|
|
|
#include "spdk/stdinc.h"
|
|
|
|
#include "spdk_cunit.h"
|
|
|
|
#include "util/math.c"
|
|
|
|
static void
|
|
test_serial_number_arithmetic(void)
|
|
{
|
|
CU_ASSERT(spdk_sn32_add(0, 1) == 1);
|
|
CU_ASSERT(spdk_sn32_add(1, 1) == 2);
|
|
CU_ASSERT(spdk_sn32_add(1, 2) == 3);
|
|
CU_ASSERT(spdk_sn32_add(1, UINT32_MAX) == 0);
|
|
CU_ASSERT(spdk_sn32_add(UINT32_MAX, UINT32_MAX) == UINT32_MAX - 1);
|
|
CU_ASSERT(spdk_sn32_gt(1, 0) == true);
|
|
CU_ASSERT(spdk_sn32_gt(2, 1) == true);
|
|
CU_ASSERT(spdk_sn32_gt(UINT32_MAX, UINT32_MAX - 1) == true);
|
|
CU_ASSERT(spdk_sn32_gt(0, UINT32_MAX) == true);
|
|
CU_ASSERT(spdk_sn32_gt(100, UINT32_MAX - 100) == true);
|
|
CU_ASSERT(spdk_sn32_lt(1, 0) == false);
|
|
CU_ASSERT(spdk_sn32_lt(2, 1) == false);
|
|
CU_ASSERT(spdk_sn32_lt(UINT32_MAX, UINT32_MAX - 1) == false);
|
|
CU_ASSERT(spdk_sn32_lt(0, UINT32_MAX) == false);
|
|
CU_ASSERT(spdk_sn32_lt(100, UINT32_MAX - 100) == false);
|
|
}
|
|
|
|
static void
|
|
test_memset_s(void)
|
|
{
|
|
char secret[] = "0123456789abcdef";
|
|
|
|
/* Zero length, nothing should be changed */
|
|
spdk_memset_s(secret, sizeof(secret), 'b', 0);
|
|
CU_ASSERT_EQUAL(memcmp(secret, "0123456789abcdef", sizeof(secret)), 0);
|
|
|
|
/* Fill digits */
|
|
spdk_memset_s(secret, sizeof(secret), 'x', 10);
|
|
CU_ASSERT_EQUAL(memcmp(secret, "xxxxxxxxxxabcdef", sizeof(secret)), 0);
|
|
|
|
/* Fill the whole string except of the NULL char */
|
|
spdk_memset_s(secret, sizeof(secret), 'y', sizeof(secret) - 1);
|
|
CU_ASSERT_EQUAL(memcmp(secret, "yyyyyyyyyyyyyyyy", sizeof(secret) - 1), 0);
|
|
}
|
|
|
|
int
|
|
main(int argc, char **argv)
|
|
{
|
|
CU_pSuite suite_math = NULL, suite_erase = NULL;
|
|
unsigned int num_failures;
|
|
|
|
CU_set_error_action(CUEA_ABORT);
|
|
CU_initialize_registry();
|
|
|
|
suite_math = CU_add_suite("math", NULL, NULL);
|
|
CU_ADD_TEST(suite_math, test_serial_number_arithmetic);
|
|
|
|
suite_erase = CU_add_suite("erase", NULL, NULL);
|
|
CU_ADD_TEST(suite_erase, test_memset_s);
|
|
|
|
CU_basic_set_mode(CU_BRM_VERBOSE);
|
|
|
|
CU_basic_run_tests();
|
|
|
|
num_failures = CU_get_number_of_failures();
|
|
CU_cleanup_registry();
|
|
|
|
return num_failures;
|
|
}
|