ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
415fa16403
Spdk/test/unit/lib/util/math.c/math_ut.c

75 lines
2.1 KiB
C
Raw Normal View History

Replace most BSD 3-clause license text with SPDX identifier. Many open source projects have moved to using SPDX identifiers to specify license information, reducing the amount of boilerplate code in every source file. This patch replaces the bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clause identifier. Almost all of these files share the exact same license text, and this patch only modifies the files that contain the most common license text. There can be slight variations because the third clause contains company names - most say "Intel Corporation", but there are instances for Nvidia, Samsung, Eideticom and even "the copyright holder". Used a bash script to automate replacement of the license text with SPDX identifier which is checked into scripts/spdx.sh. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904 Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Dong Yi <dongx.yi@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: <qun.wan@intel.com>
2022-06-03 19:15:11 +00:00
/* SPDX-License-Identifier: BSD-3-Clause
update Intel copyright notices per Intel policy to include file commit date using git cmd below. The policy does not apply to non-Intel (C) notices. git log --follow -C90% --format=%ad --date default <file> | tail -1 and then pull just the 4 digit year from the result. Intel copyrights were not added to files where Intel either had no contribution ot the contribution lacked substance (ie license header updates, formatting changes, etc). Contribution date used "--follow -C95%" to get the most accurate date. Note that several files in this patch didn't end the license/(c) block with a blank comment line so these were added as the vast majority of files do have this last blank line. Simply there for consistency. Signed-off-by: paul luse <paul.e.luse@intel.com> Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Community-CI: Mellanox Build Bot
2022-11-01 20:26:26 +00:00
* Copyright (C) 2020 Intel Corporation.
util: Add spdk_memset_s bdev_crypto uses memset() to zero secrets passed by the user (cleanup/error path) which is not safe - compiler may detect that the buffer being zeroed is not accessed any more and may "optimize" (drop) zerofying. C11 standard introduces memset_s which guarantess to change the buffer content, but this function is optional, gcc may not support it. As alternative, add not optimal from performance point of view default implementation. Add unit test to math_ut.c to avoid creating new .c file for 1 simple test Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com> Change-Id: I11c7d15610df02e4a3761a88c85f6f8c54fb4b0a Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16038 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2022-12-20 13:11:20 +00:00
* Copyright (c) 2022, NVIDIA CORPORATION & AFFILIATES.
lib/util: Add spdk_sn32_lt/gt() to compare two numbers based on serial number arithmetic Previously the macro SN32_LT and SN32_GT had been added to iSCSI library. But such comparisons may be used in other libraries. So add two inline helper functions spdk_sn32_lt() and spdk_sn32_gt() to include/spdk/util.h. Add unit test for these functions. These functions are located in header file but math.c is the place if they are located in source file. Hence add unit test as the one for math.c. The next patch replaces the macro SN32_LT and SN32_GT by spdk_sn32_lt() and spdk_sn32_gt() in iSCSI library, respectively. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: Id3e4d80fea98ad4ae1516e27b9c9e8ec6f37e7a8 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1346 Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2020-03-18 02:25:30 +00:00
* All rights reserved.
*/
#include "spdk/stdinc.h"
#include "spdk_cunit.h"
#include "util/math.c"
static void
test_serial_number_arithmetic(void)
{
CU_ASSERT(spdk_sn32_add(0, 1) == 1);
CU_ASSERT(spdk_sn32_add(1, 1) == 2);
CU_ASSERT(spdk_sn32_add(1, 2) == 3);
CU_ASSERT(spdk_sn32_add(1, UINT32_MAX) == 0);
CU_ASSERT(spdk_sn32_add(UINT32_MAX, UINT32_MAX) == UINT32_MAX - 1);
CU_ASSERT(spdk_sn32_gt(1, 0) == true);
CU_ASSERT(spdk_sn32_gt(2, 1) == true);
CU_ASSERT(spdk_sn32_gt(UINT32_MAX, UINT32_MAX - 1) == true);
CU_ASSERT(spdk_sn32_gt(0, UINT32_MAX) == true);
CU_ASSERT(spdk_sn32_gt(100, UINT32_MAX - 100) == true);
CU_ASSERT(spdk_sn32_lt(1, 0) == false);
CU_ASSERT(spdk_sn32_lt(2, 1) == false);
CU_ASSERT(spdk_sn32_lt(UINT32_MAX, UINT32_MAX - 1) == false);
CU_ASSERT(spdk_sn32_lt(0, UINT32_MAX) == false);
CU_ASSERT(spdk_sn32_lt(100, UINT32_MAX - 100) == false);
}
util: Add spdk_memset_s bdev_crypto uses memset() to zero secrets passed by the user (cleanup/error path) which is not safe - compiler may detect that the buffer being zeroed is not accessed any more and may "optimize" (drop) zerofying. C11 standard introduces memset_s which guarantess to change the buffer content, but this function is optional, gcc may not support it. As alternative, add not optimal from performance point of view default implementation. Add unit test to math_ut.c to avoid creating new .c file for 1 simple test Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com> Change-Id: I11c7d15610df02e4a3761a88c85f6f8c54fb4b0a Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16038 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2022-12-20 13:11:20 +00:00
static void
test_memset_s(void)
{
char secret[] = "0123456789abcdef";
/* Zero length, nothing should be changed */
spdk_memset_s(secret, sizeof(secret), 'b', 0);
CU_ASSERT_EQUAL(memcmp(secret, "0123456789abcdef", sizeof(secret)), 0);
/* Fill digits */
spdk_memset_s(secret, sizeof(secret), 'x', 10);
CU_ASSERT_EQUAL(memcmp(secret, "xxxxxxxxxxabcdef", sizeof(secret)), 0);
/* Fill the whole string except of the NULL char */
spdk_memset_s(secret, sizeof(secret), 'y', sizeof(secret) - 1);
CU_ASSERT_EQUAL(memcmp(secret, "yyyyyyyyyyyyyyyy", sizeof(secret) - 1), 0);
}
lib/util: Add spdk_sn32_lt/gt() to compare two numbers based on serial number arithmetic Previously the macro SN32_LT and SN32_GT had been added to iSCSI library. But such comparisons may be used in other libraries. So add two inline helper functions spdk_sn32_lt() and spdk_sn32_gt() to include/spdk/util.h. Add unit test for these functions. These functions are located in header file but math.c is the place if they are located in source file. Hence add unit test as the one for math.c. The next patch replaces the macro SN32_LT and SN32_GT by spdk_sn32_lt() and spdk_sn32_gt() in iSCSI library, respectively. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: Id3e4d80fea98ad4ae1516e27b9c9e8ec6f37e7a8 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1346 Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2020-03-18 02:25:30 +00:00
int
main(int argc, char **argv)
{
util: Add spdk_memset_s bdev_crypto uses memset() to zero secrets passed by the user (cleanup/error path) which is not safe - compiler may detect that the buffer being zeroed is not accessed any more and may "optimize" (drop) zerofying. C11 standard introduces memset_s which guarantess to change the buffer content, but this function is optional, gcc may not support it. As alternative, add not optimal from performance point of view default implementation. Add unit test to math_ut.c to avoid creating new .c file for 1 simple test Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com> Change-Id: I11c7d15610df02e4a3761a88c85f6f8c54fb4b0a Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16038 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2022-12-20 13:11:20 +00:00
CU_pSuite suite_math = NULL, suite_erase = NULL;
lib/util: Add spdk_sn32_lt/gt() to compare two numbers based on serial number arithmetic Previously the macro SN32_LT and SN32_GT had been added to iSCSI library. But such comparisons may be used in other libraries. So add two inline helper functions spdk_sn32_lt() and spdk_sn32_gt() to include/spdk/util.h. Add unit test for these functions. These functions are located in header file but math.c is the place if they are located in source file. Hence add unit test as the one for math.c. The next patch replaces the macro SN32_LT and SN32_GT by spdk_sn32_lt() and spdk_sn32_gt() in iSCSI library, respectively. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: Id3e4d80fea98ad4ae1516e27b9c9e8ec6f37e7a8 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1346 Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2020-03-18 02:25:30 +00:00
unsigned int num_failures;
ut: simplify error handling at initialization This patch changes the way that unittests initialize. The new way is shorter and simpler. It assumes that error during initialization is a fatal error, but in our cases it always is. This patch is a followp up to https://review.spdk.io/gerrit/c/spdk/spdk/+/930 lvol_ut.c is the only test that skipped because it runs same tests multiple times which is not allowed by new method. Change-Id: I0baf7ad09a35d5fca2dc4a03b4453c12c14f38a7 Signed-off-by: Vitaliy Mysak <vitaliy.mysak@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1238 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-03-11 17:59:24 +00:00
CU_set_error_action(CUEA_ABORT);
CU_initialize_registry();
lib/util: Add spdk_sn32_lt/gt() to compare two numbers based on serial number arithmetic Previously the macro SN32_LT and SN32_GT had been added to iSCSI library. But such comparisons may be used in other libraries. So add two inline helper functions spdk_sn32_lt() and spdk_sn32_gt() to include/spdk/util.h. Add unit test for these functions. These functions are located in header file but math.c is the place if they are located in source file. Hence add unit test as the one for math.c. The next patch replaces the macro SN32_LT and SN32_GT by spdk_sn32_lt() and spdk_sn32_gt() in iSCSI library, respectively. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: Id3e4d80fea98ad4ae1516e27b9c9e8ec6f37e7a8 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1346 Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2020-03-18 02:25:30 +00:00
util: Add spdk_memset_s bdev_crypto uses memset() to zero secrets passed by the user (cleanup/error path) which is not safe - compiler may detect that the buffer being zeroed is not accessed any more and may "optimize" (drop) zerofying. C11 standard introduces memset_s which guarantess to change the buffer content, but this function is optional, gcc may not support it. As alternative, add not optimal from performance point of view default implementation. Add unit test to math_ut.c to avoid creating new .c file for 1 simple test Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com> Change-Id: I11c7d15610df02e4a3761a88c85f6f8c54fb4b0a Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16038 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2022-12-20 13:11:20 +00:00
suite_math = CU_add_suite("math", NULL, NULL);
CU_ADD_TEST(suite_math, test_serial_number_arithmetic);
lib/util: Add spdk_sn32_lt/gt() to compare two numbers based on serial number arithmetic Previously the macro SN32_LT and SN32_GT had been added to iSCSI library. But such comparisons may be used in other libraries. So add two inline helper functions spdk_sn32_lt() and spdk_sn32_gt() to include/spdk/util.h. Add unit test for these functions. These functions are located in header file but math.c is the place if they are located in source file. Hence add unit test as the one for math.c. The next patch replaces the macro SN32_LT and SN32_GT by spdk_sn32_lt() and spdk_sn32_gt() in iSCSI library, respectively. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: Id3e4d80fea98ad4ae1516e27b9c9e8ec6f37e7a8 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1346 Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2020-03-18 02:25:30 +00:00
util: Add spdk_memset_s bdev_crypto uses memset() to zero secrets passed by the user (cleanup/error path) which is not safe - compiler may detect that the buffer being zeroed is not accessed any more and may "optimize" (drop) zerofying. C11 standard introduces memset_s which guarantess to change the buffer content, but this function is optional, gcc may not support it. As alternative, add not optimal from performance point of view default implementation. Add unit test to math_ut.c to avoid creating new .c file for 1 simple test Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com> Change-Id: I11c7d15610df02e4a3761a88c85f6f8c54fb4b0a Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16038 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2022-12-20 13:11:20 +00:00
suite_erase = CU_add_suite("erase", NULL, NULL);
CU_ADD_TEST(suite_erase, test_memset_s);
lib/util: Add spdk_sn32_lt/gt() to compare two numbers based on serial number arithmetic Previously the macro SN32_LT and SN32_GT had been added to iSCSI library. But such comparisons may be used in other libraries. So add two inline helper functions spdk_sn32_lt() and spdk_sn32_gt() to include/spdk/util.h. Add unit test for these functions. These functions are located in header file but math.c is the place if they are located in source file. Hence add unit test as the one for math.c. The next patch replaces the macro SN32_LT and SN32_GT by spdk_sn32_lt() and spdk_sn32_gt() in iSCSI library, respectively. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: Id3e4d80fea98ad4ae1516e27b9c9e8ec6f37e7a8 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1346 Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2020-03-18 02:25:30 +00:00
CU_basic_set_mode(CU_BRM_VERBOSE);
CU_basic_run_tests();
num_failures = CU_get_number_of_failures();
CU_cleanup_registry();
return num_failures;
}
Reference in New Issue Copy Permalink