e7c019874c
In nvme_bdev_ctrlr_create, calloc will be called with a zero size allocation request if the number of namespaces is zero. The behaviour is implementation defined if the size of the space requested is zero - calloc will either return a pointer that mustn't be dereferenced, or NULL. If NULL is returned, the nvme_bdev_ctrlr_create will fail. Only call calloc if there are a non-zero number of namespaces. Otherwise, leave the namespaces pointer with a NULL value. All references to namespaces[] are either known to be safe, or occur in the context of looping through the namespaces which will be skipped if the count is zero. The exception to this is in vbdev_opal_create, where an assert has been added to match equivalent code in bdev_ocssd_create_bdev. Tested by running unit tests on a system that returns a null pointer for a zero size allocation. Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> Change-Id: I058b0683fd9b3a20bf90e54db93ca48b9bb4e40e Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6551 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: sunshihao <sunshihao@huawei.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> |
||
|---|---|---|
| .. | ||
| bdev_nvme_cuse_rpc.c | ||
| bdev_nvme_rpc.c | ||
| bdev_nvme.c | ||
| bdev_nvme.h | ||
| bdev_ocssd_rpc.c | ||
| bdev_ocssd.c | ||
| bdev_ocssd.h | ||
| common.c | ||
| common.h | ||
| Makefile | ||
| nvme_rpc.c | ||
| vbdev_opal_rpc.c | ||
| vbdev_opal.c | ||
| vbdev_opal.h | ||