ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test/iscsi: initialize igs before adding to ig map

Browse Source 
Similar to 759e5934eb (test/iscsi: initialize pgs before adding to pg
map), make sure the spdk_scsi_ig structures are zero-initialized before
passing them to spdk_iscsi_pg_map_add_ig_map().

Fixes Valgrind "Conditional jump or move depends on uninitialised
value(s)" errors in two tests.

Change-Id: I38c095aa7c6a89cb9332618b63fe12a02bcf3c2a
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/391000
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
This commit is contained in:
Daniel Verkamp 2017-12-08 09:40:11 -07:00
parent f84443572b
commit ffc0274a08
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/unit/lib/iscsi/tgt_node.c/tgt_node_ut.c
View File

@ -324,6 +324,9 @@ node_access_multi_initiator_groups_cases(void)
char *iqn, *addr;
bool result;
memset(&ig1, 0, sizeof(ig1));
memset(&ig2, 0, sizeof(ig2));
/* target initialization */
memset(&tgtnode, 0, sizeof(struct spdk_iscsi_tgt_node));
tgtnode.name = IQN1;
@ -575,6 +578,8 @@ allow_iscsi_name_multi_maps_case(void)
char *iqn;
bool result;
memset(&ig, 0, sizeof(ig));
/* target initialization */
memset(&tgtnode, 0, sizeof(struct spdk_iscsi_tgt_node));
TAILQ_INIT(&tgtnode.pg_map_head);