From ffc0274a08467c848567d29c6d4bc042c01684b4 Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Fri, 8 Dec 2017 09:40:11 -0700 Subject: [PATCH] test/iscsi: initialize igs before adding to ig map Similar to 759e5934eb (test/iscsi: initialize pgs before adding to pg map), make sure the spdk_scsi_ig structures are zero-initialized before passing them to spdk_iscsi_pg_map_add_ig_map(). Fixes Valgrind "Conditional jump or move depends on uninitialised value(s)" errors in two tests. Change-Id: I38c095aa7c6a89cb9332618b63fe12a02bcf3c2a Signed-off-by: Daniel Verkamp Reviewed-on: https://review.gerrithub.io/391000 Reviewed-by: Jim Harris Tested-by: SPDK Automated Test System --- test/unit/lib/iscsi/tgt_node.c/tgt_node_ut.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/unit/lib/iscsi/tgt_node.c/tgt_node_ut.c b/test/unit/lib/iscsi/tgt_node.c/tgt_node_ut.c index 44797d56f..911995059 100644 --- a/test/unit/lib/iscsi/tgt_node.c/tgt_node_ut.c +++ b/test/unit/lib/iscsi/tgt_node.c/tgt_node_ut.c @@ -324,6 +324,9 @@ node_access_multi_initiator_groups_cases(void) char *iqn, *addr; bool result; + memset(&ig1, 0, sizeof(ig1)); + memset(&ig2, 0, sizeof(ig2)); + /* target initialization */ memset(&tgtnode, 0, sizeof(struct spdk_iscsi_tgt_node)); tgtnode.name = IQN1; @@ -575,6 +578,8 @@ allow_iscsi_name_multi_maps_case(void) char *iqn; bool result; + memset(&ig, 0, sizeof(ig)); + /* target initialization */ memset(&tgtnode, 0, sizeof(struct spdk_iscsi_tgt_node)); TAILQ_INIT(&tgtnode.pg_map_head);