ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lib/idxd: Removed SPDK_IDXD_FLAG_PERSISTENT flag

Browse Source 
Removed SPDK_IDXD_FLAG_PERSISTENT flag and associated code.

Change-Id: Ib4e038794792ae9866bdf344f1ec58dd04dbd483
Signed-off-by: Marcin Spiewak <marcin.spiewak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16986
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
This commit is contained in:
Marcin Spiewak 2023-02-28 09:54:15 +00:00 committed by Tomasz Zawadzki
parent 2903189c40
commit fa272c9bc6
2 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
include/spdk/idxd.h
View File

@ -35,11 +35,6 @@ extern "C" {
*/ */
#define SPDK_IDXD_FLAG_NONTEMPORAL IDXD_FLAG_CACHE_CONTROL #define SPDK_IDXD_FLAG_NONTEMPORAL IDXD_FLAG_CACHE_CONTROL
/* The following flag is optional and specifies that the destination is persistent memory. The
* low level library will not set this flag.
*/
#define SPDK_IDXD_FLAG_PERSISTENT IDXD_FLAG_DEST_STEERING_TAG
/** /**
* Opaque handle for a single IDXD channel. * Opaque handle for a single IDXD channel.
*/ */

7
lib/idxd/idxd.c
View File

@ -630,14 +630,7 @@ _idxd_flush_batch(struct spdk_idxd_io_channel *chan)
static inline void static inline void
_update_write_flags(struct spdk_idxd_io_channel *chan, struct idxd_hw_desc *desc) _update_write_flags(struct spdk_idxd_io_channel *chan, struct idxd_hw_desc *desc)
{ {
if (desc->flags & SPDK_IDXD_FLAG_PERSISTENT) {
/* recent spec changes require a different set of flags for PMEM writes */
desc->flags &= ~IDXD_FLAG_DEST_STEERING_TAG;
desc->flags &= ~IDXD_FLAG_CACHE_CONTROL;
desc->flags |= IDXD_FLAG_DEST_READBACK;
} else {
desc->flags ^= IDXD_FLAG_CACHE_CONTROL; desc->flags ^= IDXD_FLAG_CACHE_CONTROL;
}
} }
int int