From fa272c9bc68fb30877ce5c2817feaa30418666a6 Mon Sep 17 00:00:00 2001 From: Marcin Spiewak Date: Tue, 28 Feb 2023 09:54:15 +0000 Subject: [PATCH] lib/idxd: Removed SPDK_IDXD_FLAG_PERSISTENT flag Removed SPDK_IDXD_FLAG_PERSISTENT flag and associated code. Change-Id: Ib4e038794792ae9866bdf344f1ec58dd04dbd483 Signed-off-by: Marcin Spiewak Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16986 Tested-by: SPDK CI Jenkins Reviewed-by: Konrad Sztyber Reviewed-by: Ben Walker --- include/spdk/idxd.h | 5 ----- lib/idxd/idxd.c | 9 +-------- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/include/spdk/idxd.h b/include/spdk/idxd.h index 0ddee8bbb..d66ace469 100644 --- a/include/spdk/idxd.h +++ b/include/spdk/idxd.h @@ -35,11 +35,6 @@ extern "C" { */ #define SPDK_IDXD_FLAG_NONTEMPORAL IDXD_FLAG_CACHE_CONTROL -/* The following flag is optional and specifies that the destination is persistent memory. The - * low level library will not set this flag. - */ -#define SPDK_IDXD_FLAG_PERSISTENT IDXD_FLAG_DEST_STEERING_TAG - /** * Opaque handle for a single IDXD channel. */ diff --git a/lib/idxd/idxd.c b/lib/idxd/idxd.c index 430f6dcba..b4554bed4 100644 --- a/lib/idxd/idxd.c +++ b/lib/idxd/idxd.c @@ -630,14 +630,7 @@ _idxd_flush_batch(struct spdk_idxd_io_channel *chan) static inline void _update_write_flags(struct spdk_idxd_io_channel *chan, struct idxd_hw_desc *desc) { - if (desc->flags & SPDK_IDXD_FLAG_PERSISTENT) { - /* recent spec changes require a different set of flags for PMEM writes */ - desc->flags &= ~IDXD_FLAG_DEST_STEERING_TAG; - desc->flags &= ~IDXD_FLAG_CACHE_CONTROL; - desc->flags |= IDXD_FLAG_DEST_READBACK; - } else { - desc->flags ^= IDXD_FLAG_CACHE_CONTROL; - } + desc->flags ^= IDXD_FLAG_CACHE_CONTROL; } int