ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lib/ftl: check namespace for NULL during initialization

Browse Source 
spdk_nvme_ctrlr_get_ns() can return NULL, which was
not verified, but dereferenced anyway.

Change-Id: Ib0554148cc47ea3ff2afa1862ac962f284fe6d43
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/462486
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
This commit is contained in:
Tomasz Zawadzki 2019-07-18 07:31:26 -04:00 committed by Jim Harris
parent eb84a1133f
commit f75d1540e9
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/ftl/ftl_init.c
View File

@ -477,6 +477,10 @@ ftl_dev_nvme_init(struct spdk_ftl_dev *dev, const struct spdk_ftl_dev_init_opts
}
dev->ns = spdk_nvme_ctrlr_get_ns(dev->ctrlr, FTL_NSID);
if (dev->ns == NULL) {
SPDK_ERRLOG("Invalid NS (%"PRIu32")\n", FTL_NSID);
return -1;
}
dev->trid = opts->trid;
dev->md_size = spdk_nvme_ns_get_md_size(dev->ns);