From f75d1540e9e2e69d3cde32ef96d863af69ee6fbc Mon Sep 17 00:00:00 2001
From: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Date: Thu, 18 Jul 2019 07:31:26 -0400
Subject: [PATCH] lib/ftl: check namespace for NULL during initialization

spdk_nvme_ctrlr_get_ns() can return NULL, which was
not verified, but dereferenced anyway.

Change-Id: Ib0554148cc47ea3ff2afa1862ac962f284fe6d43
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/462486
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
---
 lib/ftl/ftl_init.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/ftl/ftl_init.c b/lib/ftl/ftl_init.c
index 10ce08e62..0a0276328 100644
--- a/lib/ftl/ftl_init.c
+++ b/lib/ftl/ftl_init.c
@@ -477,6 +477,10 @@ ftl_dev_nvme_init(struct spdk_ftl_dev *dev, const struct spdk_ftl_dev_init_opts
 	}
 
 	dev->ns = spdk_nvme_ctrlr_get_ns(dev->ctrlr, FTL_NSID);
+	if (dev->ns == NULL) {
+		SPDK_ERRLOG("Invalid NS (%"PRIu32")\n", FTL_NSID);
+		return -1;
+	}
 	dev->trid = opts->trid;
 	dev->md_size = spdk_nvme_ns_get_md_size(dev->ns);