ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vfiouserbuild: fix build when using dash

Browse Source 
When /bin/sh is dash (such as on Ubuntu), the build now fails with:

/bin/sh: 2: Syntax error: Missing '))'

Avoid this problem by adding a space between the opening brackets.

Signed-off-by: John Levon <john.levon@nutanix.com>
Change-Id: I420788bcfaacfafc5f060fb56866edcfe2a0f1a8
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14392
Reviewed-by: Jonathan Davies <jonathan.davies@nutanix.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
John Levon 2022-09-06 17:22:05 +01:00 committed by Tomasz Zawadzki
parent 654738ff45
commit ea8f5b2761
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
vfiouserbuild/Makefile
View File

@ -20,7 +20,7 @@ build:
$(Q)test -d $(VFIO_USER_BUILD_DIR) || \ $(Q)test -d $(VFIO_USER_BUILD_DIR) || \
CC=$(SUB_CC) meson setup $(VFIO_USER_BUILD_DIR) $(VFIO_USER_SRC_DIR) CC=$(SUB_CC) meson setup $(VFIO_USER_BUILD_DIR) $(VFIO_USER_SRC_DIR)
# Work around pre-v1.9 versions of ninja ignoring new configuration. # Work around pre-v1.9 versions of ninja ignoring new configuration.
$(Q)[ $$((ninja --version; echo 1.9) | sort --version-sort | head -n 1) \ $(Q)[ $$( (ninja --version; echo 1.9) | sort --version-sort | head -n 1) \
= 1.9 ] || sleep 0.5 = 1.9 ] || sleep 0.5
$(Q)meson configure $(VFIO_USER_BUILD_DIR) $(VFIO_USER_CFG_OPTS) $(Q)meson configure $(VFIO_USER_BUILD_DIR) $(VFIO_USER_CFG_OPTS)
$(Q)meson compile $(MESON_COMPILE_OPTS) -C $(VFIO_USER_BUILD_DIR) $(Q)meson compile $(MESON_COMPILE_OPTS) -C $(VFIO_USER_BUILD_DIR)