From ea8f5b27612fa03698a9ce3ad4bd37765d9cdfa5 Mon Sep 17 00:00:00 2001 From: John Levon Date: Tue, 6 Sep 2022 17:22:05 +0100 Subject: [PATCH] vfiouserbuild: fix build when using dash When /bin/sh is dash (such as on Ubuntu), the build now fails with: /bin/sh: 2: Syntax error: Missing '))' Avoid this problem by adding a space between the opening brackets. Signed-off-by: John Levon Change-Id: I420788bcfaacfafc5f060fb56866edcfe2a0f1a8 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14392 Reviewed-by: Jonathan Davies Reviewed-by: Changpeng Liu Reviewed-by: Tomasz Zawadzki Tested-by: SPDK CI Jenkins --- vfiouserbuild/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vfiouserbuild/Makefile b/vfiouserbuild/Makefile index af7b895d3..1968839fe 100644 --- a/vfiouserbuild/Makefile +++ b/vfiouserbuild/Makefile @@ -20,7 +20,7 @@ build: $(Q)test -d $(VFIO_USER_BUILD_DIR) || \ CC=$(SUB_CC) meson setup $(VFIO_USER_BUILD_DIR) $(VFIO_USER_SRC_DIR) # Work around pre-v1.9 versions of ninja ignoring new configuration. - $(Q)[ $$((ninja --version; echo 1.9) | sort --version-sort | head -n 1) \ + $(Q)[ $$( (ninja --version; echo 1.9) | sort --version-sort | head -n 1) \ = 1.9 ] || sleep 0.5 $(Q)meson configure $(VFIO_USER_BUILD_DIR) $(VFIO_USER_CFG_OPTS) $(Q)meson compile $(MESON_COMPILE_OPTS) -C $(VFIO_USER_BUILD_DIR)