ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test/make: remove redundant ls from ABI test

Browse Source 
"ls" is not needed in for loops based on filename
expansions.
Additionally "ls" was treated as first
element of for loop which cased "No corresponding
object" message to be printed which could be
mistakenly considered a problem during the build.

Signed-off-by: Karol Latecki <karol.latecki@intel.com>
Change-Id: If5bfdb15410da36c98d9992cd04a02906599a3e0
Signed-off-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1411
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
This commit is contained in:
Karol Latecki 2020-03-23 15:35:04 +01:00 committed by Tomasz Zawadzki
parent 3c92d9f166
commit d97d1aa577
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/make/check_so_deps.sh
View File

@ -23,7 +23,7 @@ function confirm_abi_deps() {
return 1 return 1
fi fi
for object in ls "$libdir"/libspdk_*.so; do for object in "$libdir"/libspdk_*.so; do
so_file=$(basename $object) so_file=$(basename $object)
if [ ! -f "$source_abi_dir/$so_file" ]; then if [ ! -f "$source_abi_dir/$so_file" ]; then
echo "No corresponding object for $so_file in canonical directory. Skipping." echo "No corresponding object for $so_file in canonical directory. Skipping."