From d97d1aa577e7c9656815d146860db47f1892a6e8 Mon Sep 17 00:00:00 2001
From: Karol Latecki <karol.latecki@intel.com>
Date: Mon, 23 Mar 2020 15:35:04 +0100
Subject: [PATCH] test/make: remove redundant ls from ABI test

"ls" is not needed in for loops based on filename
expansions.
Additionally "ls" was treated as first
element of for loop which cased "No corresponding
object" message to be printed which could be
mistakenly considered a problem during the build.

Signed-off-by: Karol Latecki <karol.latecki@intel.com>
Change-Id: If5bfdb15410da36c98d9992cd04a02906599a3e0
Signed-off-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1411
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
---
 test/make/check_so_deps.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/make/check_so_deps.sh b/test/make/check_so_deps.sh
index daff71fc7..a0b4e8cfd 100755
--- a/test/make/check_so_deps.sh
+++ b/test/make/check_so_deps.sh
@@ -23,7 +23,7 @@ function confirm_abi_deps() {
 		return 1
 	fi
 
-	for object in ls "$libdir"/libspdk_*.so; do
+	for object in "$libdir"/libspdk_*.so; do
 		so_file=$(basename $object)
 		if [ ! -f "$source_abi_dir/$so_file" ]; then
 			echo "No corresponding object for $so_file in canonical directory. Skipping."