ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scripts/rpc: remove default value from bdev_ocf_create

Browse Source 
Removing default options from parser command to prevent overwrite by
argparse the defaults defined in the .c files.

Signed-off-by: Jaroslaw Chachulski <jaroslawx.chachulski@intel.com>
Change-Id: I9c1ba26e2b867b91fd5f7cd91edbff1844f08c79
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12979
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
This commit is contained in:
Jaroslaw Chachulski 2022-06-08 09:59:05 -04:00 committed by Tomasz Zawadzki
parent ba81cb169e
commit cd79f1a210
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
python/spdk/rpc/bdev.py
View File

@ -141,11 +141,13 @@ def bdev_ocf_create(client, name, mode, cache_line_size, cache_bdev_name, core_b
params = {
'name': name,
'mode': mode,
'cache_line_size': cache_line_size,
'cache_bdev_name': cache_bdev_name,
'core_bdev_name': core_bdev_name,
}
if cache_line_size:
params['cache_line_size'] = cache_line_size
return client.call('bdev_ocf_create', params)

3
scripts/rpc.py
View File

@ -291,8 +291,7 @@ if __name__ == "__main__":
help='OCF cache line size. The unit is KiB',
type=int,
choices=[4, 8, 16, 32, 64],
required=False,
default=0,
required=False
)
p.add_argument('cache_bdev_name', help='Name of underlying cache bdev')
p.add_argument('core_bdev_name', help='Name of underlying core bdev')