From cd79f1a21011b82a427e67576a2abd6114731343 Mon Sep 17 00:00:00 2001
From: Jaroslaw Chachulski <jaroslawx.chachulski@intel.com>
Date: Wed, 8 Jun 2022 09:59:05 -0400
Subject: [PATCH] scripts/rpc: remove default value from bdev_ocf_create

Removing default options from parser command to prevent overwrite by
argparse the defaults defined in the .c files.

Signed-off-by: Jaroslaw Chachulski <jaroslawx.chachulski@intel.com>
Change-Id: I9c1ba26e2b867b91fd5f7cd91edbff1844f08c79
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12979
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
---
 python/spdk/rpc/bdev.py | 4 +++-
 scripts/rpc.py          | 3 +--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/python/spdk/rpc/bdev.py b/python/spdk/rpc/bdev.py
index b5b656de7..14f1db1b8 100644
--- a/python/spdk/rpc/bdev.py
+++ b/python/spdk/rpc/bdev.py
@@ -141,11 +141,13 @@ def bdev_ocf_create(client, name, mode, cache_line_size, cache_bdev_name, core_b
     params = {
         'name': name,
         'mode': mode,
-        'cache_line_size': cache_line_size,
         'cache_bdev_name': cache_bdev_name,
         'core_bdev_name': core_bdev_name,
     }
 
+    if cache_line_size:
+        params['cache_line_size'] = cache_line_size
+
     return client.call('bdev_ocf_create', params)
 
 
diff --git a/scripts/rpc.py b/scripts/rpc.py
index 798010fec..fe3929edc 100755
--- a/scripts/rpc.py
+++ b/scripts/rpc.py
@@ -291,8 +291,7 @@ if __name__ == "__main__":
         help='OCF cache line size. The unit is KiB',
         type=int,
         choices=[4, 8, 16, 32, 64],
-        required=False,
-        default=0,
+        required=False
     )
     p.add_argument('cache_bdev_name', help='Name of underlying cache bdev')
     p.add_argument('core_bdev_name', help='Name of underlying core bdev')