ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pkgdep/git: Don't install sources in parallel

Browse Source 
As stated in a66c52fd this is racy and also masks out all potential
failures since wait() will not indicate if all processes succeded
or failed, it will return only with exit status from the last
process it handled.

Change-Id: I9e2b5d01ac8f951082e0b28eeae5455ecd0c8e74
Signed-off-by: Michal Berger <michalx.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4680
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
This commit is contained in:
Michal Berger 2020-10-14 17:31:53 +02:00 committed by Jim Harris
parent 721344d778
commit c9b46ba92b
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/common/config/pkgdep/git
View File

@ -367,10 +367,9 @@ sudo mkdir -p "$GIT_REPOS"
for source in "${sources[@]}"; do for source in "${sources[@]}"; do
source_conf=${source^^} source_conf=${source^^}
if [[ ${!source_conf} == true ]]; then if [[ ${!source_conf} == true ]]; then
"$source" & "$source"
fi fi
done done
wait
if [[ $INSTALL_REFSPDK == true ]]; then if [[ $INSTALL_REFSPDK == true ]]; then
# Serialize builds as refspdk depends on spdk # Serialize builds as refspdk depends on spdk