From c9b46ba92b765a7ab83ddb1452dc85c988278f25 Mon Sep 17 00:00:00 2001 From: Michal Berger Date: Wed, 14 Oct 2020 17:31:53 +0200 Subject: [PATCH] pkgdep/git: Don't install sources in parallel As stated in a66c52fd this is racy and also masks out all potential failures since wait() will not indicate if all processes succeded or failed, it will return only with exit status from the last process it handled. Change-Id: I9e2b5d01ac8f951082e0b28eeae5455ecd0c8e74 Signed-off-by: Michal Berger Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4680 Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Tomasz Zawadzki --- test/common/config/pkgdep/git | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/common/config/pkgdep/git b/test/common/config/pkgdep/git index f2a37c6fd..e82548330 100644 --- a/test/common/config/pkgdep/git +++ b/test/common/config/pkgdep/git @@ -367,10 +367,9 @@ sudo mkdir -p "$GIT_REPOS" for source in "${sources[@]}"; do source_conf=${source^^} if [[ ${!source_conf} == true ]]; then - "$source" & + "$source" fi done -wait if [[ $INSTALL_REFSPDK == true ]]; then # Serialize builds as refspdk depends on spdk