ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sock: fix a uninitialized-variable error

Browse Source 
Valgrind reports error "epoll_ctl(event) points to uninitiazlized
byte(s)" when running unit test. Fix it by initializing variable event
to a known state.

Signed-off-by: Richael Zhuang <richael.zhuang@arm.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/453525 (master)

(cherry picked from commit 09a782dcff)
Change-Id: I756687c1077eeb632c045c316a76714aa453b918
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/457210
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
This commit is contained in:
Richael Zhuang 2019-05-07 19:01:16 +08:00 committed by Darek Stojaczyk
parent a39873a5e5
commit c7658dea37
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/sock/posix/posix.c
View File

@ -506,6 +506,7 @@ spdk_posix_sock_group_impl_add_sock(struct spdk_sock_group_impl *_group, struct
#if defined(__linux__) #if defined(__linux__)
struct epoll_event event; struct epoll_event event;
memset(&event, 0, sizeof(event));
event.events = EPOLLIN; event.events = EPOLLIN;
event.data.ptr = sock; event.data.ptr = sock;

1
lib/sock/vpp/vpp.c
View File

@ -557,6 +557,7 @@ spdk_vpp_sock_group_impl_add_sock(struct spdk_sock_group_impl *_group, struct sp
assert(group != NULL); assert(group != NULL);
assert(g_vpp_initialized); assert(g_vpp_initialized);
memset(&event, 0, sizeof(event));
event.events = EPOLLIN; event.events = EPOLLIN;
event.data.ptr = sock; event.data.ptr = sock;