From c7658dea372308b80c5b3978e40a32bdfb94a8fa Mon Sep 17 00:00:00 2001 From: Richael Zhuang Date: Tue, 7 May 2019 19:01:16 +0800 Subject: [PATCH] sock: fix a uninitialized-variable error Valgrind reports error "epoll_ctl(event) points to uninitiazlized byte(s)" when running unit test. Fix it by initializing variable event to a known state. Signed-off-by: Richael Zhuang Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/453525 (master) (cherry picked from commit 09a782dcffc604cb01a7dabe9726b71e5180b6d7) Change-Id: I756687c1077eeb632c045c316a76714aa453b918 Signed-off-by: Tomasz Zawadzki Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/457210 Tested-by: SPDK CI Jenkins Reviewed-by: Darek Stojaczyk --- lib/sock/posix/posix.c | 1 + lib/sock/vpp/vpp.c | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/sock/posix/posix.c b/lib/sock/posix/posix.c index f71193343..568fc805e 100644 --- a/lib/sock/posix/posix.c +++ b/lib/sock/posix/posix.c @@ -506,6 +506,7 @@ spdk_posix_sock_group_impl_add_sock(struct spdk_sock_group_impl *_group, struct #if defined(__linux__) struct epoll_event event; + memset(&event, 0, sizeof(event)); event.events = EPOLLIN; event.data.ptr = sock; diff --git a/lib/sock/vpp/vpp.c b/lib/sock/vpp/vpp.c index 5d8e5878e..d97b5559c 100644 --- a/lib/sock/vpp/vpp.c +++ b/lib/sock/vpp/vpp.c @@ -557,6 +557,7 @@ spdk_vpp_sock_group_impl_add_sock(struct spdk_sock_group_impl *_group, struct sp assert(group != NULL); assert(g_vpp_initialized); + memset(&event, 0, sizeof(event)); event.events = EPOLLIN; event.data.ptr = sock;