ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scripts/spdkcli: Throw exception if syntax of the 'create' portal group command is incorrect.

Browse Source 
Fixes #751

Change-Id: I6c73c563d32cf930c295b7058492a2344b38883d
Signed-off-by: Pawel Kaminski <pawelx.kaminski@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/451258
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Paweł Niedźwiecki <pawelx.niedzwiecki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
This commit is contained in:
Pawel Kaminski 2019-04-16 08:31:31 -04:00 committed by Darek Stojaczyk
parent 4d13903c58
commit c459cb6e70
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
scripts/spdkcli/ui_node_iscsi.py
View File

@ -1,3 +1,4 @@
from configshell_fb import ExecutionError
from rpc.client import JSONRPCException from rpc.client import JSONRPCException
from .ui_node import UINode from .ui_node import UINode
@ -306,6 +307,9 @@ class UIPortalGroups(UINode):
cpumask = None cpumask = None
if "@" in portal: if "@" in portal:
host, cpumask = portal.split("@") host, cpumask = portal.split("@")
if ":" not in host:
raise ExecutionError("Incorrect format of portal group. Port is missing."
"Use 'help create' to see the command syntax.")
host, port = host.rsplit(":", -1) host, port = host.rsplit(":", -1)
portals.append({'host': host, 'port': port}) portals.append({'host': host, 'port': port})
if cpumask: if cpumask: