From c459cb6e70049be7e8e0c20b05bfb094d67061b2 Mon Sep 17 00:00:00 2001 From: Pawel Kaminski Date: Tue, 16 Apr 2019 08:31:31 -0400 Subject: [PATCH] scripts/spdkcli: Throw exception if syntax of the 'create' portal group command is incorrect. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes #751 Change-Id: I6c73c563d32cf930c295b7058492a2344b38883d Signed-off-by: Pawel Kaminski Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/451258 Tested-by: SPDK CI Jenkins Reviewed-by: Paweł Niedźwiecki Reviewed-by: Jim Harris Reviewed-by: Darek Stojaczyk --- scripts/spdkcli/ui_node_iscsi.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scripts/spdkcli/ui_node_iscsi.py b/scripts/spdkcli/ui_node_iscsi.py index b0af39973..ec3040a76 100644 --- a/scripts/spdkcli/ui_node_iscsi.py +++ b/scripts/spdkcli/ui_node_iscsi.py @@ -1,3 +1,4 @@ +from configshell_fb import ExecutionError from rpc.client import JSONRPCException from .ui_node import UINode @@ -306,6 +307,9 @@ class UIPortalGroups(UINode): cpumask = None if "@" in portal: host, cpumask = portal.split("@") + if ":" not in host: + raise ExecutionError("Incorrect format of portal group. Port is missing." + "Use 'help create' to see the command syntax.") host, port = host.rsplit(":", -1) portals.append({'host': host, 'port': port}) if cpumask: