ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scripts/rpc: remove default values from bdev_split_create and

Browse Source 
nvmf_get_subsystems functions

Removing default options from parser command to prevent overwrite by
argparse the defaults defined in the .c files.

Signed-off-by: Jaroslaw Chachulski <jaroslawx.chachulski@intel.com>
Change-Id: Ibce4122aed1f6c4e22b6286f52f4295a4cc13e0c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13497
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Jaroslaw Chachulski 2022-06-30 03:33:43 -04:00 committed by Tomasz Zawadzki
parent 169bab1f1a
commit ba81cb169e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
scripts/rpc.py
View File

@ -1960,7 +1960,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse
name exist the split bdevs will be created right away, if not split bdevs will be created when base bdev became name exist the split bdevs will be created right away, if not split bdevs will be created when base bdev became
available (during examination process).""") available (during examination process).""")
p.add_argument('base_bdev', help='base bdev name') p.add_argument('base_bdev', help='base bdev name')
p.add_argument('-s', '--split-size-mb', help='size in MiB for each bdev', type=int, default=0) p.add_argument('-s', '--split-size-mb', help='size in MiB for each bdev', type=int)
p.add_argument('split_count', help="""Optional - number of split bdevs to create. Total size * split_count must not p.add_argument('split_count', help="""Optional - number of split bdevs to create. Total size * split_count must not
exceed the base bdev size.""", type=int) exceed the base bdev size.""", type=int)
p.set_defaults(func=bdev_split_create) p.set_defaults(func=bdev_split_create)
@ -2143,7 +2143,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse
print_dict(rpc.nvmf.nvmf_get_subsystems(args.client, nqn=args.nqn, tgt_name=args.tgt_name)) print_dict(rpc.nvmf.nvmf_get_subsystems(args.client, nqn=args.nqn, tgt_name=args.tgt_name))
p = subparsers.add_parser('nvmf_get_subsystems', help='Display nvmf subsystems or required subsystem') p = subparsers.add_parser('nvmf_get_subsystems', help='Display nvmf subsystems or required subsystem')
p.add_argument('nqn', help='Subsystem NQN (optional)', nargs="?", default=None) p.add_argument('nqn', help='Subsystem NQN (optional)', nargs="?")
p.add_argument('-t', '--tgt-name', help='The name of the parent NVMe-oF target (optional)', type=str) p.add_argument('-t', '--tgt-name', help='The name of the parent NVMe-oF target (optional)', type=str)
p.set_defaults(func=nvmf_get_subsystems) p.set_defaults(func=nvmf_get_subsystems)