From ba81cb169e1b9e2da8dd38c2e029ad3d6c988765 Mon Sep 17 00:00:00 2001 From: Jaroslaw Chachulski Date: Thu, 30 Jun 2022 03:33:43 -0400 Subject: [PATCH] scripts/rpc: remove default values from bdev_split_create and nvmf_get_subsystems functions Removing default options from parser command to prevent overwrite by argparse the defaults defined in the .c files. Signed-off-by: Jaroslaw Chachulski Change-Id: Ibce4122aed1f6c4e22b6286f52f4295a4cc13e0c Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13497 Tested-by: SPDK CI Jenkins Community-CI: Broadcom CI Reviewed-by: Karol Latecki Reviewed-by: Konrad Sztyber Reviewed-by: Jim Harris --- scripts/rpc.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/rpc.py b/scripts/rpc.py index f5c419597..798010fec 100755 --- a/scripts/rpc.py +++ b/scripts/rpc.py @@ -1960,7 +1960,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse name exist the split bdevs will be created right away, if not split bdevs will be created when base bdev became available (during examination process).""") p.add_argument('base_bdev', help='base bdev name') - p.add_argument('-s', '--split-size-mb', help='size in MiB for each bdev', type=int, default=0) + p.add_argument('-s', '--split-size-mb', help='size in MiB for each bdev', type=int) p.add_argument('split_count', help="""Optional - number of split bdevs to create. Total size * split_count must not exceed the base bdev size.""", type=int) p.set_defaults(func=bdev_split_create) @@ -2143,7 +2143,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse print_dict(rpc.nvmf.nvmf_get_subsystems(args.client, nqn=args.nqn, tgt_name=args.tgt_name)) p = subparsers.add_parser('nvmf_get_subsystems', help='Display nvmf subsystems or required subsystem') - p.add_argument('nqn', help='Subsystem NQN (optional)', nargs="?", default=None) + p.add_argument('nqn', help='Subsystem NQN (optional)', nargs="?") p.add_argument('-t', '--tgt-name', help='The name of the parent NVMe-oF target (optional)', type=str) p.set_defaults(func=nvmf_get_subsystems)