ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lib/nvme: correct typo in transport stats

Browse Source 
"doorbell" not "doobell"

Signed-off-by: John Levon <john.levon@nutanix.com>
Change-Id: I9261559576e72a09b63fbc984ae0ec2a2572eb2c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11841
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
This commit is contained in:
John Levon 2022-03-08 12:27:27 +00:00 committed by Tomasz Zawadzki
parent cd9fca0d20
commit ba4ffda671
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
doc/jsonrpc.md
View File

@ -3531,7 +3531,7 @@ Example response:
"cq_doorbell_updates": 518827, "cq_doorbell_updates": 518827,
"queued_requests": 0, "queued_requests": 0,
"submitted_requests": 1485543, "submitted_requests": 1485543,
"sq_doobell_updates": 516081 "sq_doorbell_updates": 516081
} }
] ]
}, },
@ -3573,7 +3573,7 @@ Example response:
"cq_doorbell_updates": 518636, "cq_doorbell_updates": 518636,
"queued_requests": 0, "queued_requests": 0,
"submitted_requests": 1478730, "submitted_requests": 1478730,
"sq_doobell_updates": 511658 "sq_doorbell_updates": 511658
} }
] ]
} }

2
examples/nvme/perf/perf.c
View File

@ -1061,7 +1061,7 @@ nvme_dump_pcie_statistics(struct spdk_nvme_transport_poll_group_stat *stat)
printf("\tcompletions: %"PRIu64"\n", pcie_stat->completions); printf("\tcompletions: %"PRIu64"\n", pcie_stat->completions);
printf("\tcq_doorbell_updates: %"PRIu64"\n", pcie_stat->cq_doorbell_updates); printf("\tcq_doorbell_updates: %"PRIu64"\n", pcie_stat->cq_doorbell_updates);
printf("\tsubmitted_requests: %"PRIu64"\n", pcie_stat->submitted_requests); printf("\tsubmitted_requests: %"PRIu64"\n", pcie_stat->submitted_requests);
printf("\tsq_doobell_updates: %"PRIu64"\n", pcie_stat->sq_doobell_updates); printf("\tsq_doorbell_updates: %"PRIu64"\n", pcie_stat->sq_doorbell_updates);
printf("\tqueued_requests: %"PRIu64"\n", pcie_stat->queued_requests); printf("\tqueued_requests: %"PRIu64"\n", pcie_stat->queued_requests);
} }

2
include/spdk/nvme.h
View File

@ -502,7 +502,7 @@ struct spdk_nvme_pcie_stat {
uint64_t cq_doorbell_updates; uint64_t cq_doorbell_updates;
uint64_t submitted_requests; uint64_t submitted_requests;
uint64_t queued_requests; uint64_t queued_requests;
uint64_t sq_doobell_updates; uint64_t sq_doorbell_updates;
}; };
struct spdk_nvme_tcp_stat { struct spdk_nvme_tcp_stat {

2
lib/nvme/nvme_pcie_internal.h
View File

@ -293,7 +293,7 @@ nvme_pcie_qpair_ring_sq_doorbell(struct spdk_nvme_qpair *qpair)
if (spdk_likely(need_mmio)) { if (spdk_likely(need_mmio)) {
spdk_wmb(); spdk_wmb();
pqpair->stat->sq_doobell_updates++; pqpair->stat->sq_doorbell_updates++;
g_thread_mmio_ctrlr = pctrlr; g_thread_mmio_ctrlr = pctrlr;
spdk_mmio_write_4(pqpair->sq_tdbl, pqpair->sq_tail); spdk_mmio_write_4(pqpair->sq_tdbl, pqpair->sq_tail);
g_thread_mmio_ctrlr = NULL; g_thread_mmio_ctrlr = NULL;

2
module/bdev/nvme/bdev_nvme_rpc.c
View File

@ -1175,7 +1175,7 @@ rpc_bdev_nvme_pcie_stats(struct spdk_json_write_ctx *w,
spdk_json_write_named_uint64(w, "cq_doorbell_updates", stat->pcie.cq_doorbell_updates); spdk_json_write_named_uint64(w, "cq_doorbell_updates", stat->pcie.cq_doorbell_updates);
spdk_json_write_named_uint64(w, "queued_requests", stat->pcie.queued_requests); spdk_json_write_named_uint64(w, "queued_requests", stat->pcie.queued_requests);
spdk_json_write_named_uint64(w, "submitted_requests", stat->pcie.submitted_requests); spdk_json_write_named_uint64(w, "submitted_requests", stat->pcie.submitted_requests);
spdk_json_write_named_uint64(w, "sq_doobell_updates", stat->pcie.sq_doobell_updates); spdk_json_write_named_uint64(w, "sq_doorbell_updates", stat->pcie.sq_doorbell_updates);
} }
static void static void