From ba4ffda6716d079cf716eff9131b59632e1434e9 Mon Sep 17 00:00:00 2001 From: John Levon Date: Tue, 8 Mar 2022 12:27:27 +0000 Subject: [PATCH] lib/nvme: correct typo in transport stats "doorbell" not "doobell" Signed-off-by: John Levon Change-Id: I9261559576e72a09b63fbc984ae0ec2a2572eb2c Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11841 Tested-by: SPDK CI Jenkins Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Reviewed-by: Changpeng Liu Reviewed-by: Tomasz Zawadzki --- doc/jsonrpc.md | 4 ++-- examples/nvme/perf/perf.c | 2 +- include/spdk/nvme.h | 2 +- lib/nvme/nvme_pcie_internal.h | 2 +- module/bdev/nvme/bdev_nvme_rpc.c | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/jsonrpc.md b/doc/jsonrpc.md index 602057cf8..ac38c5d68 100644 --- a/doc/jsonrpc.md +++ b/doc/jsonrpc.md @@ -3531,7 +3531,7 @@ Example response: "cq_doorbell_updates": 518827, "queued_requests": 0, "submitted_requests": 1485543, - "sq_doobell_updates": 516081 + "sq_doorbell_updates": 516081 } ] }, @@ -3573,7 +3573,7 @@ Example response: "cq_doorbell_updates": 518636, "queued_requests": 0, "submitted_requests": 1478730, - "sq_doobell_updates": 511658 + "sq_doorbell_updates": 511658 } ] } diff --git a/examples/nvme/perf/perf.c b/examples/nvme/perf/perf.c index 26e750749..25ec4a194 100644 --- a/examples/nvme/perf/perf.c +++ b/examples/nvme/perf/perf.c @@ -1061,7 +1061,7 @@ nvme_dump_pcie_statistics(struct spdk_nvme_transport_poll_group_stat *stat) printf("\tcompletions: %"PRIu64"\n", pcie_stat->completions); printf("\tcq_doorbell_updates: %"PRIu64"\n", pcie_stat->cq_doorbell_updates); printf("\tsubmitted_requests: %"PRIu64"\n", pcie_stat->submitted_requests); - printf("\tsq_doobell_updates: %"PRIu64"\n", pcie_stat->sq_doobell_updates); + printf("\tsq_doorbell_updates: %"PRIu64"\n", pcie_stat->sq_doorbell_updates); printf("\tqueued_requests: %"PRIu64"\n", pcie_stat->queued_requests); } diff --git a/include/spdk/nvme.h b/include/spdk/nvme.h index e0e2f3998..b748f3e09 100644 --- a/include/spdk/nvme.h +++ b/include/spdk/nvme.h @@ -502,7 +502,7 @@ struct spdk_nvme_pcie_stat { uint64_t cq_doorbell_updates; uint64_t submitted_requests; uint64_t queued_requests; - uint64_t sq_doobell_updates; + uint64_t sq_doorbell_updates; }; struct spdk_nvme_tcp_stat { diff --git a/lib/nvme/nvme_pcie_internal.h b/lib/nvme/nvme_pcie_internal.h index 663cccf82..7eb81ca5f 100644 --- a/lib/nvme/nvme_pcie_internal.h +++ b/lib/nvme/nvme_pcie_internal.h @@ -293,7 +293,7 @@ nvme_pcie_qpair_ring_sq_doorbell(struct spdk_nvme_qpair *qpair) if (spdk_likely(need_mmio)) { spdk_wmb(); - pqpair->stat->sq_doobell_updates++; + pqpair->stat->sq_doorbell_updates++; g_thread_mmio_ctrlr = pctrlr; spdk_mmio_write_4(pqpair->sq_tdbl, pqpair->sq_tail); g_thread_mmio_ctrlr = NULL; diff --git a/module/bdev/nvme/bdev_nvme_rpc.c b/module/bdev/nvme/bdev_nvme_rpc.c index 8c5ae4c8f..659c3e54e 100644 --- a/module/bdev/nvme/bdev_nvme_rpc.c +++ b/module/bdev/nvme/bdev_nvme_rpc.c @@ -1175,7 +1175,7 @@ rpc_bdev_nvme_pcie_stats(struct spdk_json_write_ctx *w, spdk_json_write_named_uint64(w, "cq_doorbell_updates", stat->pcie.cq_doorbell_updates); spdk_json_write_named_uint64(w, "queued_requests", stat->pcie.queued_requests); spdk_json_write_named_uint64(w, "submitted_requests", stat->pcie.submitted_requests); - spdk_json_write_named_uint64(w, "sq_doobell_updates", stat->pcie.sq_doobell_updates); + spdk_json_write_named_uint64(w, "sq_doorbell_updates", stat->pcie.sq_doorbell_updates); } static void