ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test/bdevio: only skip cmp & write if md separate

Browse Source 
While we do not support cmp & write with separate md we
do support it with extended LBA format, i.e. interleaved md.
The check was to permissive and we only need to skip the
test if the md is separate.

Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch>
Change-Id: I483a33c762a66036bf88e77e7fc88dcb609d391a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14138
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Jonas Pfefferle 2022-08-21 18:32:37 +02:00 committed by Jim Harris
parent 8ffe1a75f9
commit aaa1ddc3b0
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/bdev/bdevio/bdevio.c
View File

@ -639,12 +639,12 @@ blockdev_comparev_and_writev(void)
struct io_target *target = g_current_io_target; struct io_target *target = g_current_io_target;
struct spdk_bdev *bdev = target->bdev; struct spdk_bdev *bdev = target->bdev;
if (spdk_bdev_get_md_size(bdev) > 0) { if (spdk_bdev_is_md_separate(bdev)) {
/* TODO: remove this check once bdev layer properly supports /* TODO: remove this check once bdev layer properly supports
* compare and write for md-enabled bdevs. * compare and write for bdevs with separate md.
*/ */
SPDK_ERRLOG("skipping comparev_and_writev on bdev %s since it has\n" SPDK_ERRLOG("skipping comparev_and_writev on bdev %s since it has\n"
"metadata which is not supported yet.\n", "separate metadata which is not supported yet.\n",
spdk_bdev_get_name(bdev)); spdk_bdev_get_name(bdev));
return; return;
} }