From aaa1ddc3b0dcea317c344f552b82faedbc1c6f68 Mon Sep 17 00:00:00 2001 From: Jonas Pfefferle Date: Sun, 21 Aug 2022 18:32:37 +0200 Subject: [PATCH] test/bdevio: only skip cmp & write if md separate While we do not support cmp & write with separate md we do support it with extended LBA format, i.e. interleaved md. The check was to permissive and we only need to skip the test if the md is separate. Signed-off-by: Jonas Pfefferle Change-Id: I483a33c762a66036bf88e77e7fc88dcb609d391a Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14138 Tested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Jim Harris --- test/bdev/bdevio/bdevio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/bdev/bdevio/bdevio.c b/test/bdev/bdevio/bdevio.c index d58f8d48d..c62aa479c 100644 --- a/test/bdev/bdevio/bdevio.c +++ b/test/bdev/bdevio/bdevio.c @@ -639,12 +639,12 @@ blockdev_comparev_and_writev(void) struct io_target *target = g_current_io_target; struct spdk_bdev *bdev = target->bdev; - if (spdk_bdev_get_md_size(bdev) > 0) { + if (spdk_bdev_is_md_separate(bdev)) { /* TODO: remove this check once bdev layer properly supports - * compare and write for md-enabled bdevs. + * compare and write for bdevs with separate md. */ SPDK_ERRLOG("skipping comparev_and_writev on bdev %s since it has\n" - "metadata which is not supported yet.\n", + "separate metadata which is not supported yet.\n", spdk_bdev_get_name(bdev)); return; }