ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

trace: verify tpoint_id does not execeed SPDK_TRACE_MAX_TPOINT_ID

Browse Source 
Change-Id: I8b873ba2ebfd8dc4736572206caac11a51ab985e
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.gerrithub.io/434022
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
This commit is contained in:
Tomasz Zawadzki 2018-11-19 09:11:25 -05:00 committed by Jim Harris
parent 9d2f39ab0b
commit 9e2f1bff81
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/spdk/trace.h
View File

@ -195,6 +195,7 @@ void spdk_trace_record(uint16_t tpoint_id, uint16_t poller_id, uint32_t size,
* within the group, the remaining upper bits determine the tracepoint group. Each * within the group, the remaining upper bits determine the tracepoint group. Each
* tracepoint group has its own tracepoint mask. * tracepoint group has its own tracepoint mask.
*/ */
assert(tpoint_id < SPDK_TRACE_MAX_TPOINT_ID);
if (g_trace_histories == NULL || if (g_trace_histories == NULL ||
!((1ULL << (tpoint_id & 0x3F)) & g_trace_histories->flags.tpoint_mask[tpoint_id >> 6])) { !((1ULL << (tpoint_id & 0x3F)) & g_trace_histories->flags.tpoint_mask[tpoint_id >> 6])) {
return; return;
@ -224,6 +225,7 @@ void spdk_trace_record_tsc(uint64_t tsc, uint16_t tpoint_id, uint16_t poller_id,
* within the group, the remaining upper bits determine the tracepoint group. Each * within the group, the remaining upper bits determine the tracepoint group. Each
* tracepoint group has its own tracepoint mask. * tracepoint group has its own tracepoint mask.
*/ */
assert(tpoint_id < SPDK_TRACE_MAX_TPOINT_ID);
if (g_trace_histories == NULL || if (g_trace_histories == NULL ||
!((1ULL << (tpoint_id & 0x3F)) & g_trace_histories->flags.tpoint_mask[tpoint_id >> 6])) { !((1ULL << (tpoint_id & 0x3F)) & g_trace_histories->flags.tpoint_mask[tpoint_id >> 6])) {
return; return;