From 9e2f1bff81466d675881454d8907dd65b62308b0 Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Mon, 19 Nov 2018 09:11:25 -0500 Subject: [PATCH] trace: verify tpoint_id does not execeed SPDK_TRACE_MAX_TPOINT_ID Change-Id: I8b873ba2ebfd8dc4736572206caac11a51ab985e Signed-off-by: Tomasz Zawadzki Reviewed-on: https://review.gerrithub.io/434022 Chandler-Test-Pool: SPDK Automated Test System Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Darek Stojaczyk --- include/spdk/trace.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/spdk/trace.h b/include/spdk/trace.h index d246aa105..5c6c83693 100644 --- a/include/spdk/trace.h +++ b/include/spdk/trace.h @@ -195,6 +195,7 @@ void spdk_trace_record(uint16_t tpoint_id, uint16_t poller_id, uint32_t size, * within the group, the remaining upper bits determine the tracepoint group. Each * tracepoint group has its own tracepoint mask. */ + assert(tpoint_id < SPDK_TRACE_MAX_TPOINT_ID); if (g_trace_histories == NULL || !((1ULL << (tpoint_id & 0x3F)) & g_trace_histories->flags.tpoint_mask[tpoint_id >> 6])) { return; @@ -224,6 +225,7 @@ void spdk_trace_record_tsc(uint64_t tsc, uint16_t tpoint_id, uint16_t poller_id, * within the group, the remaining upper bits determine the tracepoint group. Each * tracepoint group has its own tracepoint mask. */ + assert(tpoint_id < SPDK_TRACE_MAX_TPOINT_ID); if (g_trace_histories == NULL || !((1ULL << (tpoint_id & 0x3F)) & g_trace_histories->flags.tpoint_mask[tpoint_id >> 6])) { return;