ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

conf: parse "C2HSuccess" parameter for TCP transport only

Browse Source 
"C2HSuccess" is only valid for TCP transport. So this parameter
should be looked up only for TCP transport. Without the change,
spdk_nvmf_parse_transport() would bailout early for RDMA and
other transports without every creating them.

Signed-off-by: Anil Veerabhadrappa <anil.veerabhadrappa@broadcom.com>
Change-Id: I34bdff2f4ab930516743cd5dbf022d75e60fd85c
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459571
Reviewed-by: Maciej Szwed <maciej.szwed@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Anil Veerabhadrappa 2019-06-26 22:51:46 -07:00 committed by Changpeng Liu
parent 4ebf5cef63
commit 9d1e666798
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/event/subsystems/nvmf/conf.c
View File

@ -557,12 +557,9 @@ spdk_nvmf_parse_transport(struct spdk_nvmf_parse_transport_ctx *ctx)
}
}
bval = spdk_conf_section_get_boolval(ctx->sp, "C2HSuccess", true);
if (trtype == SPDK_NVME_TRANSPORT_TCP) {
bval = spdk_conf_section_get_boolval(ctx->sp, "C2HSuccess", true);
opts.c2h_success = bval;
} else {
SPDK_ERRLOG("C2HSuccess is relevant only for TCP transport '%s'\n", type);
goto error_out;
}
transport = spdk_nvmf_transport_create(trtype, &opts);