From 9d1e66679871ad77932e59d899858b3982338e48 Mon Sep 17 00:00:00 2001 From: Anil Veerabhadrappa Date: Wed, 26 Jun 2019 22:51:46 -0700 Subject: [PATCH] conf: parse "C2HSuccess" parameter for TCP transport only "C2HSuccess" is only valid for TCP transport. So this parameter should be looked up only for TCP transport. Without the change, spdk_nvmf_parse_transport() would bailout early for RDMA and other transports without every creating them. Signed-off-by: Anil Veerabhadrappa Change-Id: I34bdff2f4ab930516743cd5dbf022d75e60fd85c Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459571 Reviewed-by: Maciej Szwed Reviewed-by: Ben Walker Reviewed-by: Darek Stojaczyk Reviewed-by: Shuhei Matsumoto Reviewed-by: Changpeng Liu Tested-by: SPDK CI Jenkins --- lib/event/subsystems/nvmf/conf.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/event/subsystems/nvmf/conf.c b/lib/event/subsystems/nvmf/conf.c index a3e0f0082..ac26f87e8 100644 --- a/lib/event/subsystems/nvmf/conf.c +++ b/lib/event/subsystems/nvmf/conf.c @@ -557,12 +557,9 @@ spdk_nvmf_parse_transport(struct spdk_nvmf_parse_transport_ctx *ctx) } } - bval = spdk_conf_section_get_boolval(ctx->sp, "C2HSuccess", true); if (trtype == SPDK_NVME_TRANSPORT_TCP) { + bval = spdk_conf_section_get_boolval(ctx->sp, "C2HSuccess", true); opts.c2h_success = bval; - } else { - SPDK_ERRLOG("C2HSuccess is relevant only for TCP transport '%s'\n", type); - goto error_out; } transport = spdk_nvmf_transport_create(trtype, &opts);