ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

app: drop -q parameter (silencing noticelog)

Browse Source 
--silence-noticelog can be used instead.

The 'q' parameter is too precious to waste it on such
minor feature.

Change-Id: I96b5f1b62a9676aac895b08b17a80d55257ea83c
Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/421735
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
This commit is contained in:
Dariusz Stojaczyk 2018-08-09 13:47:29 +02:00 committed by Jim Harris
parent f727997fd8
commit 9bd8d2b40e
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/event/app.c
View File

@ -93,8 +93,6 @@ static struct option g_cmdline_options[SPDK_APP_MAX_CMDLINE_OPTIONS + 1] = {
{"mem-channels", required_argument, NULL, MEM_CHANNELS_OPT_IDX}, {"mem-channels", required_argument, NULL, MEM_CHANNELS_OPT_IDX},
#define MASTER_CORE_OPT_IDX 'p' #define MASTER_CORE_OPT_IDX 'p'
{"master-core", required_argument, NULL, MASTER_CORE_OPT_IDX}, {"master-core", required_argument, NULL, MASTER_CORE_OPT_IDX},
#define SILENCE_NOTICELOG_OPT_IDX 'q'
{"silence-noticelog", no_argument, NULL, SILENCE_NOTICELOG_OPT_IDX},
#define RPC_SOCKET_OPT_IDX 'r' #define RPC_SOCKET_OPT_IDX 'r'
{"rpc-socket", required_argument, NULL, RPC_SOCKET_OPT_IDX}, {"rpc-socket", required_argument, NULL, RPC_SOCKET_OPT_IDX},
#define MEM_SIZE_OPT_IDX 's' #define MEM_SIZE_OPT_IDX 's'
@ -111,6 +109,8 @@ static struct option g_cmdline_options[SPDK_APP_MAX_CMDLINE_OPTIONS + 1] = {
{"huge-unlink", no_argument, NULL, HUGE_UNLINK_OPT_IDX}, {"huge-unlink", no_argument, NULL, HUGE_UNLINK_OPT_IDX},
#define PCI_WHITELIST_OPT_IDX 'W' #define PCI_WHITELIST_OPT_IDX 'W'
{"pci-whitelist", required_argument, NULL, PCI_WHITELIST_OPT_IDX}, {"pci-whitelist", required_argument, NULL, PCI_WHITELIST_OPT_IDX},
#define SILENCE_NOTICELOG_OPT_IDX 257
{"silence-noticelog", no_argument, NULL, SILENCE_NOTICELOG_OPT_IDX},
{NULL, no_argument, NULL, 0} {NULL, no_argument, NULL, 0}
}; };
@ -538,8 +538,8 @@ spdk_app_start(struct spdk_app_opts *opts, spdk_event_fn start_fn,
isatty(STDERR_FILENO) && isatty(STDERR_FILENO) &&
!strncmp(ttyname(STDERR_FILENO), "/dev/tty", strlen("/dev/tty"))) { !strncmp(ttyname(STDERR_FILENO), "/dev/tty", strlen("/dev/tty"))) {
printf("Warning: printing stderr to console terminal without -q option specified.\n"); printf("Warning: printing stderr to console terminal without -q option specified.\n");
printf("Suggest using -q to disable logging to stderr and monitor syslog, or\n"); printf("Suggest using --silence-noticelog to disable logging to stderr and\n");
printf("redirect stderr to a file.\n"); printf("monitor syslog, or redirect stderr to a file.\n");
printf("(Delaying for 10 seconds...)\n"); printf("(Delaying for 10 seconds...)\n");
sleep(10); sleep(10);
} }
@ -681,7 +681,7 @@ usage(void (*app_usage)(void))
printf(" -m, --cpumask <mask> core mask for DPDK\n"); printf(" -m, --cpumask <mask> core mask for DPDK\n");
printf(" -n, --mem-channels <num> channel number of memory channels used for DPDK\n"); printf(" -n, --mem-channels <num> channel number of memory channels used for DPDK\n");
printf(" -p, --master-core <id> master (primary) core for DPDK\n"); printf(" -p, --master-core <id> master (primary) core for DPDK\n");
printf(" -q, --silence-noticelog disable notice level logging to stderr\n"); printf(" --silence-noticelog disable notice level logging to stderr\n");
printf(" -r, --rpc-socket <path> RPC listen address (default %s)\n", SPDK_DEFAULT_RPC_ADDR); printf(" -r, --rpc-socket <path> RPC listen address (default %s)\n", SPDK_DEFAULT_RPC_ADDR);
printf(" -s, --mem-size <size> memory size in MB for DPDK (default: "); printf(" -s, --mem-size <size> memory size in MB for DPDK (default: ");
if (g_default_opts.mem_size > 0) { if (g_default_opts.mem_size > 0) {