From 9bd8d2b40eb5c5d702e3c095eba1c11d418b648a Mon Sep 17 00:00:00 2001 From: Dariusz Stojaczyk Date: Thu, 9 Aug 2018 13:47:29 +0200 Subject: [PATCH] app: drop -q parameter (silencing noticelog) --silence-noticelog can be used instead. The 'q' parameter is too precious to waste it on such minor feature. Change-Id: I96b5f1b62a9676aac895b08b17a80d55257ea83c Signed-off-by: Dariusz Stojaczyk Reviewed-on: https://review.gerrithub.io/421735 Tested-by: SPDK CI Jenkins Chandler-Test-Pool: SPDK Automated Test System Reviewed-by: Jim Harris Reviewed-by: Ben Walker --- lib/event/app.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/event/app.c b/lib/event/app.c index 0d8d5c3fc..1f9d9c1e0 100644 --- a/lib/event/app.c +++ b/lib/event/app.c @@ -93,8 +93,6 @@ static struct option g_cmdline_options[SPDK_APP_MAX_CMDLINE_OPTIONS + 1] = { {"mem-channels", required_argument, NULL, MEM_CHANNELS_OPT_IDX}, #define MASTER_CORE_OPT_IDX 'p' {"master-core", required_argument, NULL, MASTER_CORE_OPT_IDX}, -#define SILENCE_NOTICELOG_OPT_IDX 'q' - {"silence-noticelog", no_argument, NULL, SILENCE_NOTICELOG_OPT_IDX}, #define RPC_SOCKET_OPT_IDX 'r' {"rpc-socket", required_argument, NULL, RPC_SOCKET_OPT_IDX}, #define MEM_SIZE_OPT_IDX 's' @@ -111,6 +109,8 @@ static struct option g_cmdline_options[SPDK_APP_MAX_CMDLINE_OPTIONS + 1] = { {"huge-unlink", no_argument, NULL, HUGE_UNLINK_OPT_IDX}, #define PCI_WHITELIST_OPT_IDX 'W' {"pci-whitelist", required_argument, NULL, PCI_WHITELIST_OPT_IDX}, +#define SILENCE_NOTICELOG_OPT_IDX 257 + {"silence-noticelog", no_argument, NULL, SILENCE_NOTICELOG_OPT_IDX}, {NULL, no_argument, NULL, 0} }; @@ -538,8 +538,8 @@ spdk_app_start(struct spdk_app_opts *opts, spdk_event_fn start_fn, isatty(STDERR_FILENO) && !strncmp(ttyname(STDERR_FILENO), "/dev/tty", strlen("/dev/tty"))) { printf("Warning: printing stderr to console terminal without -q option specified.\n"); - printf("Suggest using -q to disable logging to stderr and monitor syslog, or\n"); - printf("redirect stderr to a file.\n"); + printf("Suggest using --silence-noticelog to disable logging to stderr and\n"); + printf("monitor syslog, or redirect stderr to a file.\n"); printf("(Delaying for 10 seconds...)\n"); sleep(10); } @@ -681,7 +681,7 @@ usage(void (*app_usage)(void)) printf(" -m, --cpumask core mask for DPDK\n"); printf(" -n, --mem-channels channel number of memory channels used for DPDK\n"); printf(" -p, --master-core master (primary) core for DPDK\n"); - printf(" -q, --silence-noticelog disable notice level logging to stderr\n"); + printf(" --silence-noticelog disable notice level logging to stderr\n"); printf(" -r, --rpc-socket RPC listen address (default %s)\n", SPDK_DEFAULT_RPC_ADDR); printf(" -s, --mem-size memory size in MB for DPDK (default: "); if (g_default_opts.mem_size > 0) {