ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvmf: check spdk_nvmf_tgt_listen() return value

Browse Source 
spdk_nvmf_tgt_listen() can fail due to invalid user input (e.g. from a
config file), so we can't just assert() that it worked.

Change-Id: Iea2d4ab2c82d79f6eada24e6082456489bf304b8
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
This commit is contained in:
Daniel Verkamp 2017-03-22 15:32:49 -07:00
parent 532de4d9df
commit 9412e60062
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/nvmf_tgt/conf.c
View File

@ -531,7 +531,13 @@ spdk_nvmf_construct_subsystem(const char *name,
listen_addr = spdk_nvmf_tgt_listen(addresses[i].transport,
addresses[i].traddr, addresses[i].trsvcid);
assert(listen_addr != NULL);
if (listen_addr == NULL) {
SPDK_ERRLOG("Failed to listen on transport %s, traddr %s, trsvcid %s\n",
addresses[i].transport,
addresses[i].traddr,
addresses[i].trsvcid);
goto error;
}
spdk_nvmf_subsystem_add_listener(subsystem, listen_addr);
}