From 9412e6006232b8ea8d13175460d78469eba12bfd Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Wed, 22 Mar 2017 15:32:49 -0700 Subject: [PATCH] nvmf: check spdk_nvmf_tgt_listen() return value spdk_nvmf_tgt_listen() can fail due to invalid user input (e.g. from a config file), so we can't just assert() that it worked. Change-Id: Iea2d4ab2c82d79f6eada24e6082456489bf304b8 Signed-off-by: Daniel Verkamp --- app/nvmf_tgt/conf.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/app/nvmf_tgt/conf.c b/app/nvmf_tgt/conf.c index 5cdc479ec..8bf1a29fc 100644 --- a/app/nvmf_tgt/conf.c +++ b/app/nvmf_tgt/conf.c @@ -531,7 +531,13 @@ spdk_nvmf_construct_subsystem(const char *name, listen_addr = spdk_nvmf_tgt_listen(addresses[i].transport, addresses[i].traddr, addresses[i].trsvcid); - assert(listen_addr != NULL); + if (listen_addr == NULL) { + SPDK_ERRLOG("Failed to listen on transport %s, traddr %s, trsvcid %s\n", + addresses[i].transport, + addresses[i].traddr, + addresses[i].trsvcid); + goto error; + } spdk_nvmf_subsystem_add_listener(subsystem, listen_addr); }