ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lib/nvme: drop unused argument

Browse Source 
nvme_pcie_qpair_update_mmio_required() qpair argument is unused.

Signed-off-by: John Levon <john.levon@nutanix.com>
Change-Id: I0bd6897eb8e6a06f211cc599ab6045409bb43641
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11842
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
John Levon 2022-03-08 12:37:04 +00:00 committed by Tomasz Zawadzki
parent fcf5ae7e4e
commit 8071e0f1dc
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lib/nvme/nvme_pcie_internal.h
View File

@ -243,7 +243,7 @@ nvme_pcie_qpair_need_event(uint16_t event_idx, uint16_t new_idx, uint16_t old)
} }
static inline bool static inline bool
nvme_pcie_qpair_update_mmio_required(struct spdk_nvme_qpair *qpair, uint16_t value, nvme_pcie_qpair_update_mmio_required(uint16_t value,
volatile uint32_t *shadow_db, volatile uint32_t *shadow_db,
volatile uint32_t *eventidx) volatile uint32_t *eventidx)
{ {
@ -285,10 +285,10 @@ nvme_pcie_qpair_ring_sq_doorbell(struct spdk_nvme_qpair *qpair)
} }
if (spdk_unlikely(pqpair->flags.has_shadow_doorbell)) { if (spdk_unlikely(pqpair->flags.has_shadow_doorbell)) {
need_mmio = nvme_pcie_qpair_update_mmio_required(qpair, need_mmio = nvme_pcie_qpair_update_mmio_required(
pqpair->sq_tail, pqpair->sq_tail,
pqpair->shadow_doorbell.sq_tdbl, pqpair->shadow_doorbell.sq_tdbl,
pqpair->shadow_doorbell.sq_eventidx); pqpair->shadow_doorbell.sq_eventidx);
} }
if (spdk_likely(need_mmio)) { if (spdk_likely(need_mmio)) {
@ -308,10 +308,10 @@ nvme_pcie_qpair_ring_cq_doorbell(struct spdk_nvme_qpair *qpair)
bool need_mmio = true; bool need_mmio = true;
if (spdk_unlikely(pqpair->flags.has_shadow_doorbell)) { if (spdk_unlikely(pqpair->flags.has_shadow_doorbell)) {
need_mmio = nvme_pcie_qpair_update_mmio_required(qpair, need_mmio = nvme_pcie_qpair_update_mmio_required(
pqpair->cq_head, pqpair->cq_head,
pqpair->shadow_doorbell.cq_hdbl, pqpair->shadow_doorbell.cq_hdbl,
pqpair->shadow_doorbell.cq_eventidx); pqpair->shadow_doorbell.cq_eventidx);
} }
if (spdk_likely(need_mmio)) { if (spdk_likely(need_mmio)) {