From 8071e0f1dcca977cd4f4e89ab3303bff8c4f0a36 Mon Sep 17 00:00:00 2001 From: John Levon Date: Tue, 8 Mar 2022 12:37:04 +0000 Subject: [PATCH] lib/nvme: drop unused argument nvme_pcie_qpair_update_mmio_required() qpair argument is unused. Signed-off-by: John Levon Change-Id: I0bd6897eb8e6a06f211cc599ab6045409bb43641 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11842 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Jim Harris --- lib/nvme/nvme_pcie_internal.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/nvme/nvme_pcie_internal.h b/lib/nvme/nvme_pcie_internal.h index 7eb81ca5f..8cc64559c 100644 --- a/lib/nvme/nvme_pcie_internal.h +++ b/lib/nvme/nvme_pcie_internal.h @@ -243,7 +243,7 @@ nvme_pcie_qpair_need_event(uint16_t event_idx, uint16_t new_idx, uint16_t old) } static inline bool -nvme_pcie_qpair_update_mmio_required(struct spdk_nvme_qpair *qpair, uint16_t value, +nvme_pcie_qpair_update_mmio_required(uint16_t value, volatile uint32_t *shadow_db, volatile uint32_t *eventidx) { @@ -285,10 +285,10 @@ nvme_pcie_qpair_ring_sq_doorbell(struct spdk_nvme_qpair *qpair) } if (spdk_unlikely(pqpair->flags.has_shadow_doorbell)) { - need_mmio = nvme_pcie_qpair_update_mmio_required(qpair, - pqpair->sq_tail, - pqpair->shadow_doorbell.sq_tdbl, - pqpair->shadow_doorbell.sq_eventidx); + need_mmio = nvme_pcie_qpair_update_mmio_required( + pqpair->sq_tail, + pqpair->shadow_doorbell.sq_tdbl, + pqpair->shadow_doorbell.sq_eventidx); } if (spdk_likely(need_mmio)) { @@ -308,10 +308,10 @@ nvme_pcie_qpair_ring_cq_doorbell(struct spdk_nvme_qpair *qpair) bool need_mmio = true; if (spdk_unlikely(pqpair->flags.has_shadow_doorbell)) { - need_mmio = nvme_pcie_qpair_update_mmio_required(qpair, - pqpair->cq_head, - pqpair->shadow_doorbell.cq_hdbl, - pqpair->shadow_doorbell.cq_eventidx); + need_mmio = nvme_pcie_qpair_update_mmio_required( + pqpair->cq_head, + pqpair->shadow_doorbell.cq_hdbl, + pqpair->shadow_doorbell.cq_eventidx); } if (spdk_likely(need_mmio)) {