ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test/iscsi: initialize mutex for portability

Browse Source 
For correct behaviour, pthread_mutex must be initialized before use.
Add static initialization to a couple of structures containing a mutex.

Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
Change-Id: I7049824bb292135dbebab201083a1858597f94d1
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6124
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: Ziye Yang <ziye.yang@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Nick Connolly 2021-01-27 17:17:14 +00:00 committed by Tomasz Zawadzki
parent 6b3ec9683e
commit 7f293c58a5
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/unit/lib/iscsi/init_grp.c/init_grp_ut.c
View File

@ -40,7 +40,9 @@
SPDK_LOG_REGISTER_COMPONENT(iscsi) SPDK_LOG_REGISTER_COMPONENT(iscsi)
struct spdk_iscsi_globals g_iscsi; struct spdk_iscsi_globals g_iscsi = {
.mutex = PTHREAD_MUTEX_INITIALIZER
};
static int static int
test_setup(void) test_setup(void)

4
test/unit/lib/iscsi/iscsi.c/iscsi_ut.c
View File

@ -54,7 +54,9 @@
#define UT_INITIATOR_NAME2 "iqn.2017-11.spdk.io:i0002" #define UT_INITIATOR_NAME2 "iqn.2017-11.spdk.io:i0002"
#define UT_ISCSI_TSIH 256 #define UT_ISCSI_TSIH 256
struct spdk_iscsi_tgt_node g_tgt; struct spdk_iscsi_tgt_node g_tgt = {
.mutex = PTHREAD_MUTEX_INITIALIZER
};
struct spdk_iscsi_tgt_node * struct spdk_iscsi_tgt_node *
iscsi_find_tgt_node(const char *target_name) iscsi_find_tgt_node(const char *target_name)