From 7f293c58a5d0d4ff77180abb89aca07b3fc7c95f Mon Sep 17 00:00:00 2001 From: Nick Connolly Date: Wed, 27 Jan 2021 17:17:14 +0000 Subject: [PATCH] test/iscsi: initialize mutex for portability For correct behaviour, pthread_mutex must be initialized before use. Add static initialization to a couple of structures containing a mutex. Signed-off-by: Nick Connolly Change-Id: I7049824bb292135dbebab201083a1858597f94d1 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6124 Reviewed-by: Paul Luse Reviewed-by: Ziye Yang Reviewed-by: Aleksey Marchuk Reviewed-by: Ben Walker Reviewed-by: Jim Harris Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins --- test/unit/lib/iscsi/init_grp.c/init_grp_ut.c | 4 +++- test/unit/lib/iscsi/iscsi.c/iscsi_ut.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/test/unit/lib/iscsi/init_grp.c/init_grp_ut.c b/test/unit/lib/iscsi/init_grp.c/init_grp_ut.c index fe3de787e..dfc2e1519 100644 --- a/test/unit/lib/iscsi/init_grp.c/init_grp_ut.c +++ b/test/unit/lib/iscsi/init_grp.c/init_grp_ut.c @@ -40,7 +40,9 @@ SPDK_LOG_REGISTER_COMPONENT(iscsi) -struct spdk_iscsi_globals g_iscsi; +struct spdk_iscsi_globals g_iscsi = { + .mutex = PTHREAD_MUTEX_INITIALIZER +}; static int test_setup(void) diff --git a/test/unit/lib/iscsi/iscsi.c/iscsi_ut.c b/test/unit/lib/iscsi/iscsi.c/iscsi_ut.c index c901e9ef4..35aaa2632 100644 --- a/test/unit/lib/iscsi/iscsi.c/iscsi_ut.c +++ b/test/unit/lib/iscsi/iscsi.c/iscsi_ut.c @@ -54,7 +54,9 @@ #define UT_INITIATOR_NAME2 "iqn.2017-11.spdk.io:i0002" #define UT_ISCSI_TSIH 256 -struct spdk_iscsi_tgt_node g_tgt; +struct spdk_iscsi_tgt_node g_tgt = { + .mutex = PTHREAD_MUTEX_INITIALIZER +}; struct spdk_iscsi_tgt_node * iscsi_find_tgt_node(const char *target_name)