ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

spdkcli/test: remove unnecessary test output

Browse Source 
Don't print output of spdkcli command if not error happened.
Such logging only polutes the CI output.

On failed commands, the output is still printed.
Mismatch between `element_exist` and `element in child.before.decode()'
  also counts as fail so we show the output in that case too.

This commit is related to trello task:
https://trello.com/c/GlJnWmkR/150-spdkcli-improve-tests-output

Change-Id: I7b20dc2bbd1a3b15a3701be27bec023614e18621
Signed-off-by: Vitaliy Mysak <vitaliy.mysak@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459305
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Pawel Kaminski <pawelx.kaminski@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Seth Howell <seth.howell5141@gmail.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
This commit is contained in:
Vitaliy Mysak 2019-06-25 21:53:55 +00:00 committed by Darek Stojaczyk
parent 294e8a2fb6
commit 719ee8be1f
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/spdkcli/spdkcli_job.py
View File

@ -15,14 +15,13 @@ def execute_command(cmd, element=None, element_exists=False):
if ls_tree and element:
child.sendline("ls %s" % ls_tree)
child.expect("/>")
print("child: %s" % child.before.decode())
if element_exists:
if element not in child.before.decode():
print("Element %s not in list" % element)
print("Element %s not in list:\n%s" % (element, child.before.decode()))
exit(1)
else:
if element in child.before.decode():
print("Element %s is in list" % element)
print("Element %s is in list:\n%s" % (element, child.before.decode()))
exit(1)