From 719ee8be1f49fa532d3bb033243a78ce3151dc2b Mon Sep 17 00:00:00 2001 From: Vitaliy Mysak Date: Tue, 25 Jun 2019 21:53:55 +0000 Subject: [PATCH] spdkcli/test: remove unnecessary test output Don't print output of spdkcli command if not error happened. Such logging only polutes the CI output. On failed commands, the output is still printed. Mismatch between `element_exist` and `element in child.before.decode()' also counts as fail so we show the output in that case too. This commit is related to trello task: https://trello.com/c/GlJnWmkR/150-spdkcli-improve-tests-output Change-Id: I7b20dc2bbd1a3b15a3701be27bec023614e18621 Signed-off-by: Vitaliy Mysak Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459305 Tested-by: SPDK CI Jenkins Reviewed-by: Pawel Kaminski Reviewed-by: Paul Luse Reviewed-by: Karol Latecki Reviewed-by: Seth Howell Reviewed-by: Ben Walker Reviewed-by: Darek Stojaczyk --- test/spdkcli/spdkcli_job.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/spdkcli/spdkcli_job.py b/test/spdkcli/spdkcli_job.py index 70a957bba..b3a4da9aa 100755 --- a/test/spdkcli/spdkcli_job.py +++ b/test/spdkcli/spdkcli_job.py @@ -15,14 +15,13 @@ def execute_command(cmd, element=None, element_exists=False): if ls_tree and element: child.sendline("ls %s" % ls_tree) child.expect("/>") - print("child: %s" % child.before.decode()) if element_exists: if element not in child.before.decode(): - print("Element %s not in list" % element) + print("Element %s not in list:\n%s" % (element, child.before.decode())) exit(1) else: if element in child.before.decode(): - print("Element %s is in list" % element) + print("Element %s is in list:\n%s" % (element, child.before.decode())) exit(1)