ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvmf/tcp: remove redundant memset

Browse Source 
Minor optimisation done by code analysis, both cmd and dif are
overridden in TCP_REQUEST_STATE_NEW.

Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com>
Change-Id: I6bae4ddae175035d029c0693f7e4351b95a296ab
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/478604
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Jacek Kalwas 2019-12-24 11:20:17 +01:00 committed by Tomasz Zawadzki
parent 66af6221a0
commit 5b87daa92f
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/nvmf/tcp.c
View File

@ -358,13 +358,12 @@ spdk_nvmf_tcp_req_get(struct spdk_nvmf_tcp_qpair *tqpair)
return NULL; return NULL;
} }
memset(&tcp_req->cmd, 0, sizeof(tcp_req->cmd));
memset(&tcp_req->rsp, 0, sizeof(tcp_req->rsp)); memset(&tcp_req->rsp, 0, sizeof(tcp_req->rsp));
tcp_req->next_expected_r2t_offset = 0; tcp_req->next_expected_r2t_offset = 0;
tcp_req->r2tl_remain = 0; tcp_req->r2tl_remain = 0;
tcp_req->c2h_data_offset = 0; tcp_req->c2h_data_offset = 0;
tcp_req->has_incapsule_data = false; tcp_req->has_incapsule_data = false;
memset(&tcp_req->req.dif, 0, sizeof(tcp_req->req.dif)); tcp_req->req.dif.dif_insert_or_strip = false;
spdk_nvmf_tcp_req_set_state(tcp_req, TCP_REQUEST_STATE_NEW); spdk_nvmf_tcp_req_set_state(tcp_req, TCP_REQUEST_STATE_NEW);
return tcp_req; return tcp_req;