From 5b87daa92f01b99065fd9db9d9f403f08fdb271b Mon Sep 17 00:00:00 2001 From: Jacek Kalwas Date: Tue, 24 Dec 2019 11:20:17 +0100 Subject: [PATCH] nvmf/tcp: remove redundant memset Minor optimisation done by code analysis, both cmd and dif are overridden in TCP_REQUEST_STATE_NEW. Signed-off-by: Jacek Kalwas Change-Id: I6bae4ddae175035d029c0693f7e4351b95a296ab Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/478604 Tested-by: SPDK CI Jenkins Community-CI: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris --- lib/nvmf/tcp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/nvmf/tcp.c b/lib/nvmf/tcp.c index 62cb3df1a..135a5ef25 100644 --- a/lib/nvmf/tcp.c +++ b/lib/nvmf/tcp.c @@ -358,13 +358,12 @@ spdk_nvmf_tcp_req_get(struct spdk_nvmf_tcp_qpair *tqpair) return NULL; } - memset(&tcp_req->cmd, 0, sizeof(tcp_req->cmd)); memset(&tcp_req->rsp, 0, sizeof(tcp_req->rsp)); tcp_req->next_expected_r2t_offset = 0; tcp_req->r2tl_remain = 0; tcp_req->c2h_data_offset = 0; tcp_req->has_incapsule_data = false; - memset(&tcp_req->req.dif, 0, sizeof(tcp_req->req.dif)); + tcp_req->req.dif.dif_insert_or_strip = false; spdk_nvmf_tcp_req_set_state(tcp_req, TCP_REQUEST_STATE_NEW); return tcp_req;