ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iscsi: Add DataSequenceInOrder in discovery_ignored_param

Browse Source 
The implementation of Calsoft case tc_login_29_1
is wrong. We should return "Irrelevant" to the initiator
when Session type is discovery.

Also also update the known failure test cases of
Calsoft.

Fixes 958.

Signed-off-by: Ziye Yang <ziye.yang@intel.com>
Change-Id: I38cd2cf39bf80fd025ab74bc9dfe6ac412d01328
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2846
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
This commit is contained in:
Ziye Yang 2020-06-11 00:11:37 +08:00 committed by Jim Harris
parent b7200d0eb8
commit 41219b2b9e
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/iscsi/param.c
View File

@ -514,6 +514,7 @@ static const char *discovery_ignored_param[] = {
"FirstBurstLength" "FirstBurstLength"
"MaxOutstandingR2T", "MaxOutstandingR2T",
"DataPDUInOrder", "DataPDUInOrder",
"DataSequenceInOrder",
NULL, NULL,
}; };

8
test/iscsi_tgt/calsoft/calsoft.py
View File

@ -28,11 +28,17 @@ A standard-label MUST begin with a capital letter and must not exceed
63 characters. 63 characters.
key name: A standard-label key name: A standard-label
''' '''
'''
06/10/2020 add tc_login_29_1 to known_failed_cases
RFC 3720 12.19. DataSequenceInOrder
Irrelevant when: SessionType=Discovery
'''
known_failed_cases = ['tc_ffp_15_2', 'tc_ffp_29_2', 'tc_ffp_29_3', 'tc_ffp_29_4', known_failed_cases = ['tc_ffp_15_2', 'tc_ffp_29_2', 'tc_ffp_29_3', 'tc_ffp_29_4',
'tc_err_1_1', 'tc_err_1_2', 'tc_err_2_8', 'tc_err_1_1', 'tc_err_1_2', 'tc_err_2_8',
'tc_err_3_1', 'tc_err_3_2', 'tc_err_3_3', 'tc_err_3_1', 'tc_err_3_2', 'tc_err_3_3',
'tc_err_3_4', 'tc_err_5_1', 'tc_login_3_1', 'tc_err_3_4', 'tc_err_5_1', 'tc_login_3_1',
'tc_login_11_2', 'tc_login_11_4', 'tc_login_2_2'] 'tc_login_11_2', 'tc_login_11_4', 'tc_login_2_2', 'tc_login_29_1']
def run_case(case, result_list, log_dir_path): def run_case(case, result_list, log_dir_path):