From 41219b2b9eb477f68399ee8589879adf6ae9b306 Mon Sep 17 00:00:00 2001 From: Ziye Yang Date: Thu, 11 Jun 2020 00:11:37 +0800 Subject: [PATCH] iscsi: Add DataSequenceInOrder in discovery_ignored_param The implementation of Calsoft case tc_login_29_1 is wrong. We should return "Irrelevant" to the initiator when Session type is discovery. Also also update the known failure test cases of Calsoft. Fixes 958. Signed-off-by: Ziye Yang Change-Id: I38cd2cf39bf80fd025ab74bc9dfe6ac412d01328 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2846 Reviewed-by: Shuhei Matsumoto Reviewed-by: Tomasz Zawadzki Reviewed-by: Ben Walker Reviewed-by: Jim Harris Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build Bot --- lib/iscsi/param.c | 1 + test/iscsi_tgt/calsoft/calsoft.py | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/iscsi/param.c b/lib/iscsi/param.c index 9b1400435..18f579359 100644 --- a/lib/iscsi/param.c +++ b/lib/iscsi/param.c @@ -514,6 +514,7 @@ static const char *discovery_ignored_param[] = { "FirstBurstLength" "MaxOutstandingR2T", "DataPDUInOrder", + "DataSequenceInOrder", NULL, }; diff --git a/test/iscsi_tgt/calsoft/calsoft.py b/test/iscsi_tgt/calsoft/calsoft.py index ad1e551f4..5be658e61 100755 --- a/test/iscsi_tgt/calsoft/calsoft.py +++ b/test/iscsi_tgt/calsoft/calsoft.py @@ -28,11 +28,17 @@ A standard-label MUST begin with a capital letter and must not exceed 63 characters. key name: A standard-label ''' +''' +06/10/2020 add tc_login_29_1 to known_failed_cases +RFC 3720 12.19. DataSequenceInOrder +Irrelevant when: SessionType=Discovery +''' + known_failed_cases = ['tc_ffp_15_2', 'tc_ffp_29_2', 'tc_ffp_29_3', 'tc_ffp_29_4', 'tc_err_1_1', 'tc_err_1_2', 'tc_err_2_8', 'tc_err_3_1', 'tc_err_3_2', 'tc_err_3_3', 'tc_err_3_4', 'tc_err_5_1', 'tc_login_3_1', - 'tc_login_11_2', 'tc_login_11_4', 'tc_login_2_2'] + 'tc_login_11_2', 'tc_login_11_4', 'tc_login_2_2', 'tc_login_29_1'] def run_case(case, result_list, log_dir_path):