ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvmf/tcp: Remove pdu ref count

Browse Source 
This wasn't actually used. Every PDU only had a single reference.

Change-Id: I8adaa7edeca5fe175aa853c156df741170d76c10
Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/479902
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com>
Community-CI: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Ziye Yang <ziye.yang@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Ben Walker 2020-01-08 12:48:40 -07:00 committed by Tomasz Zawadzki
parent 52f1e4b029
commit 2112c8bf3a
2 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/spdk_internal/nvme_tcp.h
View File

@ -107,7 +107,6 @@ struct nvme_tcp_pdu {
uint8_t ch_valid_bytes; uint8_t ch_valid_bytes;
uint8_t psh_valid_bytes; uint8_t psh_valid_bytes;
uint8_t psh_len; uint8_t psh_len;
int ref;
nvme_tcp_qpair_xfer_complete_cb cb_fn; nvme_tcp_qpair_xfer_complete_cb cb_fn;
void *cb_arg; void *cb_arg;

10
lib/nvmf/tcp.c
View File

@ -328,7 +328,6 @@ spdk_nvmf_tcp_pdu_get(struct spdk_nvmf_tcp_qpair *tqpair)
TAILQ_REMOVE(&tqpair->free_queue, pdu, tailq); TAILQ_REMOVE(&tqpair->free_queue, pdu, tailq);
memset(pdu, 0, sizeof(*pdu)); memset(pdu, 0, sizeof(*pdu));
pdu->qpair = tqpair; pdu->qpair = tqpair;
pdu->ref = 1;
pdu->hdr = &pdu->hdr_mem; pdu->hdr = &pdu->hdr_mem;
return pdu; return pdu;
@ -337,18 +336,9 @@ spdk_nvmf_tcp_pdu_get(struct spdk_nvmf_tcp_qpair *tqpair)
static void static void
spdk_nvmf_tcp_pdu_put(struct spdk_nvmf_tcp_qpair *tqpair, struct nvme_tcp_pdu *pdu) spdk_nvmf_tcp_pdu_put(struct spdk_nvmf_tcp_qpair *tqpair, struct nvme_tcp_pdu *pdu)
{ {
if (!pdu) {
return;
}
assert(pdu->ref > 0);
pdu->ref--;
if (pdu->ref == 0) {
tqpair->free_pdu_num++; tqpair->free_pdu_num++;
TAILQ_INSERT_HEAD(&tqpair->free_queue, pdu, tailq); TAILQ_INSERT_HEAD(&tqpair->free_queue, pdu, tailq);
} }
}
static struct spdk_nvmf_tcp_req * static struct spdk_nvmf_tcp_req *
spdk_nvmf_tcp_req_get(struct spdk_nvmf_tcp_qpair *tqpair) spdk_nvmf_tcp_req_get(struct spdk_nvmf_tcp_qpair *tqpair)